pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart - Issue 2727343002: Calculate text ranges for default args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

Issue 2727343002: Calculate text ranges for default args. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

index f10cd4b3055996b11e2f7409e2ab2b008a0caa06..1dba712997a50eb998e04eb855482d7415724158 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

@@ -481,8 +481,7 @@ class _LocalVisitor extends LocalDeclarationVisitor {

.map((p) => p.element);

suggestion.hasNamedParameters = namedParameters.isNotEmpty;

- suggestion.defaultArgumentListString =

- buildDefaultArgList(requiredParameters, namedParameters);

+ addDefaultArgDetails(suggestion, requiredParameters, namedParameters);

}

bool _isVoid(TypeAnnotation returnType) {

« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart » ('j') | no next file with comments »