Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2727343002: Calculate text ranges for default args. (Closed)

Created:
3 years, 9 months ago by pquitslund
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Calculate text ranges for default args. Continued work on generating sensible default contents for args in completions. Calculated text ranges allow us to produce linked edits in the IDE. BUG= R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/cc0036d5ad46793b9399443f4d62e3a4c1680320

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
pquitslund
3 years, 9 months ago (2017-03-02 20:54:54 UTC) #2
scheglov
LGTM
3 years, 9 months ago (2017-03-02 20:57:18 UTC) #3
Brian Wilkerson
lgtm
3 years, 9 months ago (2017-03-02 21:05:05 UTC) #4
pquitslund
3 years, 9 months ago (2017-03-02 21:14:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cc0036d5ad46793b9399443f4d62e3a4c1680320 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698