Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2727273003: Prevent preliminary blacklisted features from being used too early (Closed)

Created:
3 years, 9 months ago by sugoi1
Modified:
3 years, 9 months ago
Reviewers:
Zhenyao Mo, jbauman
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent preliminary blacklisted features from being used too early EnableSwiftShaderIfNecessary() was calling GpuAccessAllowed() before UpdatePreliminaryBlacklistedFeatures() was called, causing GpuAccessAllowed() to return false because of the uninitialized preliminary blacklisted features list. This simply adds a check that prevents using uninitialized data. BUG=697998 Review-Url: https://codereview.chromium.org/2727273003 Cr-Commit-Position: refs/heads/master@{#454432} Committed: https://chromium.googlesource.com/chromium/src/+/2df232659f116970f80a6d492ec5945173690e2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -20 lines) Patch
M content/browser/gpu/gpu_data_manager_impl_private.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 3 chunks +24 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
sugoi1
It looks like this fix works. Thanks zmo@!
3 years, 9 months ago (2017-03-02 19:56:12 UTC) #3
jbauman
lgtm
3 years, 9 months ago (2017-03-02 22:24:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727273003/1
3 years, 9 months ago (2017-03-02 23:24:17 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 23:33:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2df232659f116970f80a6d492ec5...

Powered by Google App Engine
This is Rietveld 408576698