Uses child views in Autofill Popup so we can trigger

chrome/browser/ui/autofill/autofill_popup_view.h

Index: chrome/browser/ui/autofill/autofill_popup_view.h
diff --git a/chrome/browser/ui/autofill/autofill_popup_view.h b/chrome/browser/ui/autofill/autofill_popup_view.h
index 4bb752fe467bf8df3249916f09268fbc35640c29..b31f32b171f4d0b03b64eaf7f79dcca84ac2aca2 100644
--- a/chrome/browser/ui/autofill/autofill_popup_view.h
+++ b/chrome/browser/ui/autofill/autofill_popup_view.h
@@ -7,8 +7,10 @@
 
 #include <stddef.h>
 
+#include "base/optional.h"
 #include "base/strings/string16.h"
 #include "chrome/browser/ui/autofill/autofill_popup_view_delegate.h"
+#include "ui/accessibility/ax_enums.h"

[groby-ooo-7-16, 2017/03/20 20:42:55]

Why are ax_enums.h included?

[csashi, 2017/03/20 21:41:51]

Done.

 
 namespace autofill {
 
@@ -24,11 +26,13 @@ class AutofillPopupView {
   // Hides the popup from view. This will cause the popup to be deleted.
   virtual void Hide() = 0;
 
-  // Invalidates the given row and redraw it.
-  virtual void InvalidateRow(size_t row) = 0;

[groby-ooo-7-16, 2017/03/20 20:42:55]

Why does using child views necessitate an API change?

[csashi, 2017/03/20 21:41:51]

Using child views does not necessitate an API change, but accessibility
supported needs some API change.

Please look at response in
https://codereview.chromium.org/2727233003/diff/300001/chrome/browser/ui/coco...

+  // If not null, invalidates the given rows and redraws them.
+  virtual void OnSelectedRowChanged(
+      base::Optional<int> previous_row_selection,
+      base::Optional<int> current_row_selection) = 0;
 
-  // Refreshes the position of the popup.
-  virtual void UpdateBoundsAndRedrawPopup() = 0;
+  // Refreshes the position and redraws popup when suggestions change.
+  virtual void OnSuggestionsChanged() = 0;
 
   // Factory function for creating the view.
   static AutofillPopupView* Create(AutofillPopupController* controller);