Uses child views in Autofill Popup so we can trigger

chrome/browser/ui/autofill/autofill_popup_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_POPUP_VIEW_H_
 #define CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_POPUP_VIEW_H_
 
 #include <stddef.h>
 
+#include "base/optional.h"
 #include "base/strings/string16.h"
 #include "chrome/browser/ui/autofill/autofill_popup_view_delegate.h"
+#include "ui/accessibility/ax_enums.h"

[groby-ooo-7-16, 2017/03/20 20:42:55]

Why are ax_enums.h included?

[csashi, 2017/03/20 21:41:51]

Done.

 
 namespace autofill {
 
 class AutofillPopupController;
 
 // The interface for creating and controlling a platform-dependent
 // AutofillPopupView.
 class AutofillPopupView {
  public:
   // Displays the Autofill popup and fills it in with data from the controller.
   virtual void Show() = 0;
 
   // Hides the popup from view. This will cause the popup to be deleted.
   virtual void Hide() = 0;
 
-  // Invalidates the given row and redraw it.
-  virtual void InvalidateRow(size_t row) = 0;

[groby-ooo-7-16, 2017/03/20 20:42:55]

Why does using child views necessitate an API change?

[csashi, 2017/03/20 21:41:51]

Using child views does not necessitate an API change, but accessibility
supported needs some API change.

Please look at response in
https://codereview.chromium.org/2727233003/diff/300001/chrome/browser/ui/coco...

+  // If not null, invalidates the given rows and redraws them.
+  virtual void OnSelectedRowChanged(
+      base::Optional<int> previous_row_selection,
+      base::Optional<int> current_row_selection) = 0;
 
-  // Refreshes the position of the popup.
-  virtual void UpdateBoundsAndRedrawPopup() = 0;
+  // Refreshes the position and redraws popup when suggestions change.
+  virtual void OnSuggestionsChanged() = 0;
 
   // Factory function for creating the view.
   static AutofillPopupView* Create(AutofillPopupController* controller);
 
  protected:
   virtual ~AutofillPopupView() {}
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_POPUP_VIEW_H_