Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5471)

Unified Diff: chrome/browser/ui/android/autofill/autofill_popup_view_android.h

Issue 2727233003: Uses child views in Autofill Popup so we can trigger (Closed)
Patch Set: Switches from size_t to int when we are not referring to size of an object. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/autofill_popup_view_android.h
diff --git a/chrome/browser/ui/android/autofill/autofill_popup_view_android.h b/chrome/browser/ui/android/autofill/autofill_popup_view_android.h
index 81874e5d48d8e35e2bfedb220ff335d492a92853..0e7014f642442ecedb7843c1f8391fc2518bab29 100644
--- a/chrome/browser/ui/android/autofill/autofill_popup_view_android.h
+++ b/chrome/browser/ui/android/autofill/autofill_popup_view_android.h
@@ -11,6 +11,7 @@
#include "base/android/scoped_java_ref.h"
#include "base/compiler_specific.h"
#include "base/macros.h"
+#include "base/optional.h"
sky 2017/03/20 15:50:32 Similar comment as to other header.
csashi 2017/03/20 18:11:42 Can you confirm we don't use IWYU?
#include "chrome/browser/ui/autofill/autofill_popup_view.h"
#include "ui/android/view_android.h"
@@ -46,8 +47,10 @@ class AutofillPopupViewAndroid : public AutofillPopupView {
// AutofillPopupView implementation.
void Show() override;
void Hide() override;
- void InvalidateRow(size_t row) override;
- void UpdateBoundsAndRedrawPopup() override;
+ void OnSelectedRowChanged(
+ base::Optional<int> previous_row_selection,
+ base::Optional<int> current_row_selection) override {}
sky 2017/03/20 15:50:32 Similar comment about override.
csashi 2017/03/20 18:11:42 Done.
+ void OnSuggestionsChanged() override;
private:
~AutofillPopupViewAndroid() override;

Powered by Google App Engine
This is Rietveld 408576698