Uses child views in Autofill Popup so we can trigger

chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h

Index: chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h
diff --git a/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h b/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h
index 78081db9331f8f7a15fe57ed5d2e70be68c5250d..cd990abd243884c6beb1599679d6817f6b1631de 100644
--- a/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h
+++ b/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h
@@ -12,6 +12,7 @@
 #include "base/android/scoped_java_ref.h"
 #include "base/compiler_specific.h"
 #include "base/macros.h"
+#include "base/optional.h"

[sky, 2017/03/20 15:50:32]

The use of optional comes from chrome/browser/ui/autofill/autofill_popup_view.h,
so you shouldn't need it here.

[csashi, 2017/03/20 18:11:42]

Can you confirm we don't do IWYU in chrome?

"""
For symbols used by bar.h, bar.h must #include or forward-declare what it uses.
"""
https://sites.google.com/a/google.com/iwyu-fixit/?pli=1

[sky, 2017/03/20 20:10:49]

When I asked the other members of my office of this specific case, they felt
IWYU does not apply (which I agree with). Your are overriding a function whose
signature is defined in the super-class, you should not need to include all the
headers the super-class includes as well. Similarly you wouldn't forward declare
all the declarations of the super-class that you have to override as well in the
subclass.

 #include "chrome/browser/ui/autofill/autofill_popup_view.h"
 
 namespace autofill {
@@ -50,8 +51,10 @@ class AutofillKeyboardAccessoryView : public AutofillPopupView {
   // AutofillPopupView implementation.
   void Show() override;
   void Hide() override;
-  void InvalidateRow(size_t row) override;
-  void UpdateBoundsAndRedrawPopup() override;
+  void OnSelectedRowChanged(
+      base::Optional<int> previous_row_selection,
+      base::Optional<int> current_row_selection) override {}

[sky, 2017/03/20 15:50:32]

Don't inline overrides (see chromium style guide).

[csashi, 2017/03/20 18:11:42]

Done.

+  void OnSuggestionsChanged() override;
 
  private:
   ~AutofillKeyboardAccessoryView() override;