Uses child views in Autofill Popup so we can trigger

chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_ANDROID_AUTOFILL_AUTOFILL_KEYBOARD_ACCESSORY_VIEW_H_
 #define CHROME_BROWSER_UI_ANDROID_AUTOFILL_AUTOFILL_KEYBOARD_ACCESSORY_VIEW_H_
 
 #include <jni.h>
 #include <stddef.h>
 #include <vector>
 
 #include "base/android/scoped_java_ref.h"
 #include "base/compiler_specific.h"
 #include "base/macros.h"
+#include "base/optional.h"

[sky, 2017/03/20 15:50:32]

The use of optional comes from chrome/browser/ui/autofill/autofill_popup_view.h,
so you shouldn't need it here.

[csashi, 2017/03/20 18:11:42]

Can you confirm we don't do IWYU in chrome?

"""
For symbols used by bar.h, bar.h must #include or forward-declare what it uses.
"""
https://sites.google.com/a/google.com/iwyu-fixit/?pli=1

[sky, 2017/03/20 20:10:49]

When I asked the other members of my office of this specific case, they felt
IWYU does not apply (which I agree with). Your are overriding a function whose
signature is defined in the super-class, you should not need to include all the
headers the super-class includes as well. Similarly you wouldn't forward declare
all the declarations of the super-class that you have to override as well in the
subclass.

 #include "chrome/browser/ui/autofill/autofill_popup_view.h"
 
 namespace autofill {
 
 class AutofillPopupController;
 
 // A suggestion view that acts as an alternative to the field-attached popup
 // window. This view appears above the keyboard and spans the width of the
 // screen, condensing rather than overlaying the content area. Enable via
 // --enable-autofill-keyboard-accessory-view.
@@ skipping 18 matching lines @@
 
   void ViewDismissed(JNIEnv* env,
                      const base::android::JavaParamRef<jobject>& obj);
 
   static bool RegisterAutofillKeyboardAccessoryView(JNIEnv* env);
 
  protected:
   // AutofillPopupView implementation.
   void Show() override;
   void Hide() override;
-  void InvalidateRow(size_t row) override;
-  void UpdateBoundsAndRedrawPopup() override;
+  void OnSelectedRowChanged(
+      base::Optional<int> previous_row_selection,
+      base::Optional<int> current_row_selection) override {}

[sky, 2017/03/20 15:50:32]

Don't inline overrides (see chromium style guide).

[csashi, 2017/03/20 18:11:42]

Done.

+  void OnSuggestionsChanged() override;
 
  private:
   ~AutofillKeyboardAccessoryView() override;
 
   AutofillPopupController* controller_;  // weak.
 
   // The index of the last item the user long-pressed (they will be shown a
   // confirmation dialog).
   int deleting_index_;
 
   // Mapping from Java list index to autofill suggestion index.
   std::vector<int> positions_;
 
   // The corresponding java object.
   base::android::ScopedJavaGlobalRef<jobject> java_object_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillKeyboardAccessoryView);
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_UI_ANDROID_AUTOFILL_AUTOFILL_KEYBOARD_ACCESSORY_VIEW_H_