Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc

Issue 2727233003: Uses child views in Autofill Popup so we can trigger (Closed)
Patch Set: Switches from size_t to int when we are not referring to size of an object. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h" 5 #include "chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "chrome/browser/android/resource_mapper.h" 9 #include "chrome/browser/android/resource_mapper.h"
10 #include "chrome/browser/ui/android/view_android_helper.h" 10 #include "chrome/browser/ui/android/view_android_helper.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 } 58 }
59 59
60 void AutofillKeyboardAccessoryView::Show() { 60 void AutofillKeyboardAccessoryView::Show() {
61 JNIEnv* env = base::android::AttachCurrentThread(); 61 JNIEnv* env = base::android::AttachCurrentThread();
62 ui::ViewAndroid* view_android = controller_->container_view(); 62 ui::ViewAndroid* view_android = controller_->container_view();
63 DCHECK(view_android); 63 DCHECK(view_android);
64 Java_AutofillKeyboardAccessoryBridge_init( 64 Java_AutofillKeyboardAccessoryBridge_init(
65 env, java_object_, reinterpret_cast<intptr_t>(this), 65 env, java_object_, reinterpret_cast<intptr_t>(this),
66 view_android->GetWindowAndroid()->GetJavaObject()); 66 view_android->GetWindowAndroid()->GetJavaObject());
67 67
68 UpdateBoundsAndRedrawPopup(); 68 OnSuggestionsChanged();
69 } 69 }
70 70
71 void AutofillKeyboardAccessoryView::Hide() { 71 void AutofillKeyboardAccessoryView::Hide() {
72 controller_ = nullptr; 72 controller_ = nullptr;
73 JNIEnv* env = base::android::AttachCurrentThread(); 73 JNIEnv* env = base::android::AttachCurrentThread();
74 Java_AutofillKeyboardAccessoryBridge_dismiss(env, java_object_); 74 Java_AutofillKeyboardAccessoryBridge_dismiss(env, java_object_);
75 } 75 }
76 76
77 void AutofillKeyboardAccessoryView::UpdateBoundsAndRedrawPopup() { 77 void AutofillKeyboardAccessoryView::OnSuggestionsChanged() {
78 JNIEnv* env = base::android::AttachCurrentThread(); 78 JNIEnv* env = base::android::AttachCurrentThread();
79 size_t count = controller_->GetLineCount(); 79 size_t count = controller_->GetLineCount();
80 ScopedJavaLocalRef<jobjectArray> data_array = 80 ScopedJavaLocalRef<jobjectArray> data_array =
81 Java_AutofillKeyboardAccessoryBridge_createAutofillSuggestionArray(env, 81 Java_AutofillKeyboardAccessoryBridge_createAutofillSuggestionArray(env,
82 count); 82 count);
83 positions_.resize(count); 83 positions_.resize(count);
84 size_t position = 0; 84 size_t position = 0;
85 85
86 // Place "CLEAR FORM" item first in the list. 86 // Place "CLEAR FORM" item first in the list.
87 for (size_t i = 0; i < count; ++i) { 87 for (size_t i = 0; i < count; ++i) {
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 151
152 void AutofillKeyboardAccessoryView::ViewDismissed( 152 void AutofillKeyboardAccessoryView::ViewDismissed(
153 JNIEnv* env, 153 JNIEnv* env,
154 const JavaParamRef<jobject>& obj) { 154 const JavaParamRef<jobject>& obj) {
155 if (controller_) 155 if (controller_)
156 controller_->ViewDestroyed(); 156 controller_->ViewDestroyed();
157 157
158 delete this; 158 delete this;
159 } 159 }
160 160
161 void AutofillKeyboardAccessoryView::InvalidateRow(size_t) {
162 }
163
164 // static 161 // static
165 bool AutofillKeyboardAccessoryView::RegisterAutofillKeyboardAccessoryView( 162 bool AutofillKeyboardAccessoryView::RegisterAutofillKeyboardAccessoryView(
166 JNIEnv* env) { 163 JNIEnv* env) {
167 return RegisterNativesImpl(env); 164 return RegisterNativesImpl(env);
168 } 165 }
169 166
170 } // namespace autofill 167 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698