Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2727173002: Change VisibleUnits::nextBoundary to return Position rather than VisiblePosition (Closed)

Created:
3 years, 9 months ago by yoichio
Modified:
3 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change VisibleUnits::nextBoundary to return Position rather than VisiblePosition This is preparation for letting |startOfWord| and |endOfWord| return uncanonicalized Position. BUG=697725 Review-Url: https://codereview.chromium.org/2727173002 Cr-Commit-Position: refs/heads/master@{#454464} Committed: https://chromium.googlesource.com/chromium/src/+/2df2529a06975711ece271e92ea111ac6ea8d21a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 6 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
yoichio
3 years, 9 months ago (2017-03-02 08:17:09 UTC) #6
yosin_UTC9
lgtm
3 years, 9 months ago (2017-03-02 08:19:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727173002/1
3 years, 9 months ago (2017-03-03 01:57:21 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 02:04:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2df2529a06975711ece271e92ea1...

Powered by Google App Engine
This is Rietveld 408576698