mediaview: Add a typemap for arc::mojom::ChangeType.

mediaview: Add a typemap for arc::mojom::ChangeType.

Also fixes storage/browser/BUILD.gn, which is needed to pass gn gen --check.

BUG=chromium:698623
TEST=gn gen --check

Review-Url: https://codereview.chromium.org/2727113002
Cr-Commit-Position: refs/heads/master@{#455662}
Committed: https://chromium.googlesource.com/chromium/src/+/af461a2d3b3a487c28cec7c5392da1d26df81f97

[Shuhei Takahashi, 2017-03-02 02:02:35]

Description was changed from

==========
WIP: Add a typemap for arc::mojom::ChangeType.

Currently GN check fails for following errors:

ERROR at //storage/browser/fileapi/isolated_file_system_backend.cc:30:11:
Include not allowed.
          ^----------------------------------------
It is not in any dependency of
  //storage/browser:browser
The include file is in the target(s):
  //components/arc:arc_bindings
which should somehow be reachable.

BUG=chromium:684233
TEST=gn gen --check FAILS
==========

to

==========
WIP: Add a typemap for arc::mojom::ChangeType.

Currently GN check fails for the error below. Without --check, build itself
succeeds.

ERROR at //storage/browser/fileapi/isolated_file_system_backend.cc:30:11:
Include not allowed.
          ^----------------------------------------
It is not in any dependency of
  //storage/browser:browser
The include file is in the target(s):
  //components/arc:arc_bindings
which should somehow be reachable.

BUG=chromium:684233
TEST=gn gen --check FAILS
==========

[Shuhei Takahashi, 2017-03-02 02:05:45]

nya@chromium.org changed reviewers:
+ dcheng@chromium.org

[Shuhei Takahashi, 2017-03-02 02:05:46]

dcheng: PTAL

I'm glad if you could help me resolving the GN error.

[Shuhei Takahashi, 2017-03-02 02:05:46]

nya@chromium.org changed reviewers:
+ dcheng@chromium.org

[Shuhei Takahashi, 2017-03-02 02:05:46]

dcheng: PTAL

I'm glad if you could help me resolving the GN error.

[Shuhei Takahashi, 2017-03-02 04:06:18]

Description was changed from

==========
WIP: Add a typemap for arc::mojom::ChangeType.

Currently GN check fails for the error below. Without --check, build itself
succeeds.

ERROR at //storage/browser/fileapi/isolated_file_system_backend.cc:30:11:
Include not allowed.
          ^----------------------------------------
It is not in any dependency of
  //storage/browser:browser
The include file is in the target(s):
  //components/arc:arc_bindings
which should somehow be reachable.

BUG=chromium:684233
TEST=gn gen --check FAILS
==========

to

==========
Add a typemap for arc::mojom::ChangeType.

BUG=chromium:684233
TEST=gn gen --check
==========

[Shuhei Takahashi, 2017-03-02 04:06:53]

Description was changed from

==========
Add a typemap for arc::mojom::ChangeType.

BUG=chromium:684233
TEST=gn gen --check
==========

to

==========
Add a typemap for arc::mojom::ChangeType.

Also fixes storage/browser/BUILD.gn, which is needed to pass gn gen --check.

BUG=chromium:684233
TEST=gn gen --check
==========

[Shuhei Takahashi, 2017-03-02 04:07:01]

The CQ bit was checked by nya@chromium.org to run a CQ dry run

[Shuhei Takahashi, 2017-03-02 04:07:39]

On 2017/03/02 02:05:46, Shuhei Takahashi wrote:
> dcheng: PTAL
> 
> I'm glad if you could help me resolving the GN error.

OK, I found that it's because watcher_manager.h is not included in
storage/browser/BUILD.gn. Now gn gen --check passes.

[commit-bot: I haz the power, 2017-03-02 04:07:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shuhei Takahashi, 2017-03-02 07:08:33]

Description was changed from

==========
Add a typemap for arc::mojom::ChangeType.

Also fixes storage/browser/BUILD.gn, which is needed to pass gn gen --check.

BUG=chromium:684233
TEST=gn gen --check
==========

to

==========
mediaview: Add a typemap for arc::mojom::ChangeType.

Also fixes storage/browser/BUILD.gn, which is needed to pass gn gen --check.

BUG=chromium:684233
TEST=gn gen --check
==========

[dcheng, 2017-03-02 07:26:36]

LGTM with comment addressed

https://codereview.chromium.org/2727113002/diff/20001/components/arc/file_sys...
File components/arc/file_system/file_system_struct_traits.h (right):

https://codereview.chromium.org/2727113002/diff/20001/components/arc/file_sys...
components/arc/file_system/file_system_struct_traits.h:22: return
arc::mojom::ChangeType::DELETED;
In general, we prefer to out-of-line not-obviously trivial methods. In this
case, it should optimize pretty well since the enum values on both sides should
match, but it's not obvious from reading the code.

If you want to keep inline, I guess one option is to static_cast and then have
static_assert that the enum values match. Up to you.

[Shuhei Takahashi, 2017-03-02 07:45:09]

The CQ bit was checked by nya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 07:45:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shuhei Takahashi, 2017-03-02 07:45:44]

dcheng: PTAL (I guess I need your approval again for
file_system_struct_traits.cc).

https://codereview.chromium.org/2727113002/diff/20001/components/arc/file_sys...
File components/arc/file_system/file_system_struct_traits.h (right):

https://codereview.chromium.org/2727113002/diff/20001/components/arc/file_sys...
components/arc/file_system/file_system_struct_traits.h:22: return
arc::mojom::ChangeType::DELETED;
On 2017/03/02 07:26:36, dcheng wrote:
> In general, we prefer to out-of-line not-obviously trivial methods. In this
> case, it should optimize pretty well since the enum values on both sides
should
> match, but it's not obvious from reading the code.
> 
> If you want to keep inline, I guess one option is to static_cast and then have
> static_assert that the enum values match. Up to you.

Hmm, OK, please let me move this definition to out-of-line. I'm hesitant to use
static_cast because new enum values might be added to
storage::WatcherManager::ChangeType without noticing.

[commit-bot: I haz the power, 2017-03-02 08:37:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 08:38:00]

Dry run: This issue passed the CQ dry run.

[Shuhei Takahashi, 2017-03-02 08:39:20]

nya@chromium.org changed reviewers:
+ hidehiko@chromium.org, kinuko@chromium.org

[Shuhei Takahashi, 2017-03-02 08:39:21]

hidehiko: PTAL for chrome/browser/chromeos/arc and components/arc

dcheng: PTAL for security review

kinuko: PTAL for storage/browser/BUILD.gn

[kinuko, 2017-03-02 09:11:21]

lgtm

[hidehiko, 2017-03-02 09:15:58]

LGTM for arc except files security review need.

[Shuhei Takahashi, 2017-03-03 15:50:15]

The CQ bit was checked by nya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 15:50:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 16:14:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 16:14:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Shuhei Takahashi, 2017-03-03 16:29:04]

The CQ bit was checked by nya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 16:29:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 17:25:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 17:25:24]

Dry run: This issue passed the CQ dry run.

[Shuhei Takahashi, 2017-03-06 02:54:35]

Description was changed from

==========
mediaview: Add a typemap for arc::mojom::ChangeType.

Also fixes storage/browser/BUILD.gn, which is needed to pass gn gen --check.

BUG=chromium:684233
TEST=gn gen --check
==========

to

==========
mediaview: Add a typemap for arc::mojom::ChangeType.

Also fixes storage/browser/BUILD.gn, which is needed to pass gn gen --check.

BUG=chromium:698623
TEST=gn gen --check
==========

[Shuhei Takahashi, 2017-03-09 01:45:54]

The CQ bit was checked by nya@chromium.org

[Shuhei Takahashi, 2017-03-09 01:45:55]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org,
hidehiko@chromium.org, kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2727113002/#ps60001
(title: "Rebased to ToT.")

[commit-bot: I haz the power, 2017-03-09 01:46:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 04:05:48]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489023954782940,
"parent_rev": "7ccc32b63d2ba1ff62e6aeb8f178fd6403b4c51a", "commit_rev":
"af461a2d3b3a487c28cec7c5392da1d26df81f97"}

[commit-bot: I haz the power, 2017-03-09 04:07:27]

Description was changed from

==========
mediaview: Add a typemap for arc::mojom::ChangeType.

Also fixes storage/browser/BUILD.gn, which is needed to pass gn gen --check.

BUG=chromium:698623
TEST=gn gen --check
==========

to

==========
mediaview: Add a typemap for arc::mojom::ChangeType.

Also fixes storage/browser/BUILD.gn, which is needed to pass gn gen --check.

BUG=chromium:698623
TEST=gn gen --check

Review-Url: https://codereview.chromium.org/2727113002
Cr-Commit-Position: refs/heads/master@{#455662}
Committed:
https://chromium.googlesource.com/chromium/src/+/af461a2d3b3a487c28cec7c5392d...
==========

[commit-bot: I haz the power, 2017-03-09 04:07:28]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/af461a2d3b3a487c28cec7c5392d...

[Shuhei Takahashi, 2017-03-09 06:37:04]

On 2017/03/09 04:07:28, commit-bot: I haz the power wrote:
> Committed patchset #4 (id:60001) as
>
https://chromium.googlesource.com/chromium/src/+/af461a2d3b3a487c28cec7c5392d...

Hmm, I could commit the patch. Anyway, difference between PS2 and PS3 is subtle
(just moved function definitions out-of-line).