Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2727103002: Remove GoogleNowNotification stats collector (Closed)

Created:
3 years, 9 months ago by skare_
Modified:
3 years, 9 months ago
Reviewers:
dewittj
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GoogleNowNotification stats collector BUG=539674 Review-Url: https://codereview.chromium.org/2727103002 Cr-Commit-Position: refs/heads/master@{#455117} Committed: https://chromium.googlesource.com/chromium/src/+/406eb9a4cce877003ea00c22be552b1794b248e9

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -134 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/notifications/google_now_notification_stats_collector.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/notifications/google_now_notification_stats_collector.cc View 1 chunk +0 lines, -82 lines 0 comments Download
M chrome/browser/notifications/message_center_notification_manager.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/notifications/message_center_notification_manager.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
skare_
dewittj@chromium.org: Please review changes in /chrome/browser/notifications/...
3 years, 9 months ago (2017-03-06 22:13:57 UTC) #8
dewittj
lgtm
3 years, 9 months ago (2017-03-06 22:19:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727103002/20001
3 years, 9 months ago (2017-03-07 02:16:57 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/395373)
3 years, 9 months ago (2017-03-07 05:42:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727103002/20001
3 years, 9 months ago (2017-03-07 15:23:33 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 17:31:13 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/406eb9a4cce877003ea00c22be55...

Powered by Google App Engine
This is Rietveld 408576698