Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2727003006: [turbofan] Drop obsolete unused JSStrictNotEqual operator. (Closed)

Created:
3 years, 9 months ago by Benedikt Meurer
Modified:
3 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Drop obsolete unused JSStrictNotEqual operator. We don't need the JSStrictNotEqual operator in the compiler, because this is never generated by the BytecodeGraphBuilder, and the code in the AstGraphBuilder was dead code. Also remove the backing builtin StrictNotEqual. R=mstarzinger@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2727003006 Cr-Commit-Position: refs/heads/master@{#43594} Committed: https://chromium.googlesource.com/v8/v8/+/9ef1e35bc6c6ef2ddb55211563f169bbc3eaecb3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -86 lines) Patch
M src/builtins/builtins.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/builtins/builtins-number.cc View 1 chunk +1 line, -9 lines 0 comments Download
M src/code-factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/code-factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/code-stub-assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stub-assembler.cc View 4 chunks +5 lines, -8 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/compiler/js-operator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/js-type-hint-lowering.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 3 chunks +16 lines, -19 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/operator-properties.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M test/unittests/compiler/typer-unittest.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 9 months ago (2017-03-03 13:13:42 UTC) #1
Michael Starzinger
LGTM. Nice!
3 years, 9 months ago (2017-03-03 15:35:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727003006/1
3 years, 9 months ago (2017-03-03 17:57:39 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 17:59:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9ef1e35bc6c6ef2ddb55211563f169bbc3e...

Powered by Google App Engine
This is Rietveld 408576698