Output a linker map file for official builds

Output a linker map file for official builds

I intend to use the map file for binary size analysis.

Map file is gzipped, and is about 20MB for Android.
Adds ~2.5 seconds onto a 30 second link on my z620.

BUG=681694
Review-Url: https://codereview.chromium.org/2726983004
Cr-Commit-Position: refs/heads/master@{#455482}
Committed: https://chromium.googlesource.com/chromium/src/+/7d275da6c61c065510dcbcbd237636891d4b435a

[agrieve, 2017-03-02 16:42:51]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 16:43:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 17:40:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 17:40:12]

Dry run: This issue passed the CQ dry run.

[agrieve, 2017-03-03 18:10:56]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 18:11:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2017-03-03 18:14:54]

Description was changed from

==========
Output a linker map file for official builds (posix only)

I intend to use the map file for binary size analysis.

Map file is gzipped, and is about 20MB for Android.
Adds ~2.5 seconds onto a 30s link on a z620.

BUG=681694
==========

to

==========
Output a linker map file for official builds

I intend to use the map file for binary size analysis.

Map file is gzipped, and is about 20MB for Android.
Adds ~2.5 seconds onto a 30 second link on my z620.

BUG=681694
==========

[agrieve, 2017-03-03 18:14:54]

agrieve@chromium.org changed reviewers:
+ dpranke@chromium.org

[agrieve, 2017-03-03 18:15:19]

On 2017/03/03 18:14:54, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:dpranke@chromium.org

📴

[agrieve, 2017-03-03 20:13:21]

On 2017/03/03 18:15:19, agrieve wrote:
> On 2017/03/03 18:14:54, agrieve wrote:
> > mailto:agrieve@chromium.org changed reviewers:
> > + mailto:dpranke@chromium.org
> 
> 📴

Note: I used PS2 to run the bots with the flag always enabled.

[Dirk Pranke, 2017-03-03 21:38:49]

https://codereview.chromium.org/2726983004/diff/40001/build/toolchain/gcc_too...
File build/toolchain/gcc_toolchain.gni (right):

https://codereview.chromium.org/2726983004/diff/40001/build/toolchain/gcc_too...
build/toolchain/gcc_toolchain.gni:326: if (is_official_build) {
This'll affect linux and chromeos too, right? Is that intentional? For Linux,
due to LTO, a 10% impact is not small.

[agrieve, 2017-03-04 02:01:26]

https://codereview.chromium.org/2726983004/diff/40001/build/toolchain/gcc_too...
File build/toolchain/gcc_toolchain.gni (right):

https://codereview.chromium.org/2726983004/diff/40001/build/toolchain/gcc_too...
build/toolchain/gcc_toolchain.gni:326: if (is_official_build) {
On 2017/03/03 21:38:48, Dirk Pranke wrote:
> This'll affect linux and chromeos too, right? Is that intentional? For Linux,
> due to LTO, a 10% impact is not small.

It was intentional, since the size analysis tool should work just the same on
these other platforms as well.

On one hand, I can certainly get quite far by making this android only.
OTOH, my 10% number came from adding 3 seconds to my 30 second link. I suspect
it would also add around 3 seconds to an lto link, which wouldn't be too bad.

[Dirk Pranke, 2017-03-04 02:58:58]

On 2017/03/04 02:01:26, agrieve wrote:
>
https://codereview.chromium.org/2726983004/diff/40001/build/toolchain/gcc_too...
> File build/toolchain/gcc_toolchain.gni (right):
> 
>
https://codereview.chromium.org/2726983004/diff/40001/build/toolchain/gcc_too...
> build/toolchain/gcc_toolchain.gni:326: if (is_official_build) {
> On 2017/03/03 21:38:48, Dirk Pranke wrote:
> > This'll affect linux and chromeos too, right? Is that intentional? For
Linux,
> > due to LTO, a 10% impact is not small.
> 
> It was intentional, since the size analysis tool should work just the same on
> these other platforms as well.
> 
> On one hand, I can certainly get quite far by making this android only.
> OTOH, my 10% number came from adding 3 seconds to my 30 second link. I suspect
> it would also add around 3 seconds to an lto link, which wouldn't be too bad.

If it's a fixed 3-second cost, then I don't care.

If you change how Linux and CrOS work, you're on the hook to make sure that's
the case :).

lgtm.

[agrieve, 2017-03-07 02:20:45]

On 2017/03/04 02:58:58, Dirk Pranke wrote:
> On 2017/03/04 02:01:26, agrieve wrote:
> >
>
https://codereview.chromium.org/2726983004/diff/40001/build/toolchain/gcc_too...
> > File build/toolchain/gcc_toolchain.gni (right):
> > 
> >
>
https://codereview.chromium.org/2726983004/diff/40001/build/toolchain/gcc_too...
> > build/toolchain/gcc_toolchain.gni:326: if (is_official_build) {
> > On 2017/03/03 21:38:48, Dirk Pranke wrote:
> > > This'll affect linux and chromeos too, right? Is that intentional? For
> Linux,
> > > due to LTO, a 10% impact is not small.
> > 
> > It was intentional, since the size analysis tool should work just the same
on
> > these other platforms as well.
> > 
> > On one hand, I can certainly get quite far by making this android only.
> > OTOH, my 10% number came from adding 3 seconds to my 30 second link. I
suspect
> > it would also add around 3 seconds to an lto link, which wouldn't be too
bad.
> 
> If it's a fixed 3-second cost, then I don't care.
> 
> If you change how Linux and CrOS work, you're on the hook to make sure that's
> the case :).
> 
> lgtm.

Well, you convinced me to test linux, and doing so made me realize that we need
.map for executables as well. Adding it to executables made nacl quite unhappy,
so I enabled it only on a per-toolchain basis. ptal.

[Dirk Pranke, 2017-03-07 02:30:00]

lgtm

[agrieve, 2017-03-08 15:52:48]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2017-03-08 15:53:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 17:23:14]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488988368758250,
"parent_rev": "fce9ee917f910870ff0f2a8d421d36421fff9838", "commit_rev":
"7d275da6c61c065510dcbcbd237636891d4b435a"}

[commit-bot: I haz the power, 2017-03-08 17:23:58]

Description was changed from

==========
Output a linker map file for official builds

I intend to use the map file for binary size analysis.

Map file is gzipped, and is about 20MB for Android.
Adds ~2.5 seconds onto a 30 second link on my z620.

BUG=681694
==========

to

==========
Output a linker map file for official builds

I intend to use the map file for binary size analysis.

Map file is gzipped, and is about 20MB for Android.
Adds ~2.5 seconds onto a 30 second link on my z620.

BUG=681694

Review-Url: https://codereview.chromium.org/2726983004
Cr-Commit-Position: refs/heads/master@{#455482}
Committed:
https://chromium.googlesource.com/chromium/src/+/7d275da6c61c065510dcbcbd2376...
==========

[commit-bot: I haz the power, 2017-03-08 17:23:59]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/7d275da6c61c065510dcbcbd2376...