Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2726923005: Clear started transitions overwritten by duration 0 transitions on the same property (Closed)

Created:
3 years, 9 months ago by alancutter (OOO until 2018)
Modified:
3 years, 9 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear started transitions overwritten by duration 0 transitions on the same property This patch ensures that transitions on properties don't start if they're specified with 0s duration but have non-zero duration in prior transition layers. Example: "transition: all 1s, left 0s" should not start transitions on left. BUG=695875 Review-Url: https://codereview.chromium.org/2726923005 Cr-Commit-Position: refs/heads/master@{#454200} Committed: https://chromium.googlesource.com/chromium/src/+/0c248cbece92af7bedfba65d35ac875153206f85

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/transitions/transition-property-layer-collision.html View 1 chunk +40 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
alancutter (OOO until 2018)
3 years, 9 months ago (2017-03-02 01:45:38 UTC) #2
Eric Willigers
lgtm
3 years, 9 months ago (2017-03-02 03:17:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726923005/1
3 years, 9 months ago (2017-03-02 03:23:51 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 07:13:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0c248cbece92af7bedfba65d35ac...

Powered by Google App Engine
This is Rietveld 408576698