Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2726903002: [chromedriver] Re-enable window & screenshot tests on HEAD. (Closed)

Created:
3 years, 9 months ago by gmanikpure
Modified:
3 years, 9 months ago
Reviewers:
samuong
CC:
chromium-reviews, samuong+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Re-enable window & screenshot tests on HEAD. Note: Not re-enabling these tests on M57 because the revision build used for v57tests on bot is old and does not contain the new fixes. BUG=chromedriver:1625 Review-Url: https://codereview.chromium.org/2726903002 Cr-Commit-Position: refs/heads/master@{#454020} Committed: https://chromium.googlesource.com/chromium/src/+/a515dc389dc5e4a6ecf5583f35692c3e3e724406

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M chrome/test/chromedriver/test/run_py_tests.py View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/test/chromedriver/test/test_expectations View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
gmanikpure
3 years, 9 months ago (2017-03-01 17:47:53 UTC) #2
samuong
lgtm
3 years, 9 months ago (2017-03-01 19:53:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726903002/1
3 years, 9 months ago (2017-03-01 19:54:23 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 20:29:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a515dc389dc5e4a6ecf5583f3569...

Powered by Google App Engine
This is Rietveld 408576698