Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1589)

Unified Diff: components/doodle/doodle_fetcher_impl.h

Issue 2726883002: [Doodle] Replace the expiry_date in DoodleConfig by time_to_live (Closed)
Patch Set: review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/doodle/doodle_fetcher_impl.cc » ('j') | components/doodle/doodle_types.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/doodle/doodle_fetcher_impl.h
diff --git a/components/doodle/doodle_fetcher_impl.h b/components/doodle/doodle_fetcher_impl.h
index 53dcbd5b5b9e969b64b5c6c8ccca62c9fa85f815..3f3eb19aeaa8042f8ce42b174c448f22f96fff2a 100644
--- a/components/doodle/doodle_fetcher_impl.h
+++ b/components/doodle/doodle_fetcher_impl.h
@@ -15,7 +15,6 @@
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
#include "base/optional.h"
-#include "base/time/clock.h"
#include "components/doodle/doodle_fetcher.h"
#include "components/doodle/doodle_types.h"
#include "net/url_request/url_fetcher_delegate.h"
@@ -54,11 +53,6 @@ class DoodleFetcherImpl : public DoodleFetcher, public net::URLFetcherDelegate {
// result from the next completed request.
void FetchDoodle(FinishedCallback callback) override;
- // Overrides internal clock for testing purposes.
- void SetClockForTesting(std::unique_ptr<base::Clock> clock) {
- clock_ = std::move(clock);
- }
-
private:
// net::URLFetcherDelegate implementation.
void OnURLFetchComplete(const net::URLFetcher* source) override;
@@ -91,9 +85,6 @@ class DoodleFetcherImpl : public DoodleFetcher, public net::URLFetcherDelegate {
ParseJSONCallback json_parsing_callback_;
GoogleURLTracker* google_url_tracker_;
- // Allow for an injectable clock for testing.
- std::unique_ptr<base::Clock> clock_;
-
std::vector<FinishedCallback> callbacks_;
std::unique_ptr<net::URLFetcher> fetcher_;
« no previous file with comments | « no previous file | components/doodle/doodle_fetcher_impl.cc » ('j') | components/doodle/doodle_types.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698