[Doodle] Replace the expiry_date in DoodleConfig by time_to_live

components/doodle/doodle_types.cc

Index: components/doodle/doodle_types.cc
diff --git a/components/doodle/doodle_types.cc b/components/doodle/doodle_types.cc
index c0a1dffde8b2ae79f784ee5f294b67a6c07fe3ac..7468d2b8f87e656456520756d89802ae1fc90925 100644
--- a/components/doodle/doodle_types.cc
+++ b/components/doodle/doodle_types.cc
@@ -16,10 +16,9 @@ bool DoodleImage::operator!=(const DoodleImage& other) const {
 }
 
 bool DoodleConfig::IsEquivalent(const DoodleConfig& other) const {
-  // Note: This compares all fields except for |expiry_date|. The reason is that
-  // |expiry_date| gets computed as "now + time_to_live", so when an identical
-  // config gets re-fetched, the expiry date will generally end up slightly
-  // different.
+  // Note: This compares all fields except for |time_to_live|, which by
+  // definition isn't constant over time, and shouldn't be in DoodleConfig in
+  // the first place.

[mastiz, 2017/03/02 13:50:13]

Nit: it's not obvious to me that time_to_live isn't constant over time.

[Marc Treib, 2017/03/02 13:53:04]

Well, it's a TimeDelta, so it's relative to "now". Anyway, the CL that removes
it from here is already out: https://codereview.chromium.org/2725143003/

   return doodle_type == other.doodle_type && alt_text == other.alt_text &&
          interactive_html == other.interactive_html &&
          search_url == other.search_url && target_url == other.target_url &&