Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Issue 2726873002: Rename third_party/freetype-android to third_party/freetype (Closed)

Created:
3 years, 9 months ago by drott
Modified:
3 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename third_party/freetype-android to third_party/freetype Now that the FreeType checkouts are unified, we should no longer use the _android suffix. TBR'ing jochen for the rename, not adding any new library. BUG=697015 TBR=jochen Review-Url: https://codereview.chromium.org/2726873002 Cr-Commit-Position: refs/heads/master@{#454855} Committed: https://chromium.googlesource.com/chromium/src/+/fe896a85ac3ab250cc5cad0e857da7ef32283a11

Patch Set 1 #

Patch Set 2 : additional BUILD.gn fixes #

Patch Set 3 : Remove outdated comment in build/linux/BUILD.gn #

Patch Set 4 : DEPS Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1132 lines) Patch
M DEPS View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M build/linux/BUILD.gn View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M skia/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/freetype-android/.clang-format View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/freetype-android/BUILD.gn View 1 2 3 1 chunk +0 lines, -84 lines 0 comments Download
D third_party/freetype-android/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/freetype-android/README.chromium View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/freetype-android/include/freetype-android-config/ftmodule.h View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/freetype-android/include/freetype-android-config/ftoption.h View 1 chunk +0 lines, -969 lines 0 comments Download
A + third_party/freetype/.clang-format View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/freetype/BUILD.gn View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + third_party/freetype/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/freetype/README.chromium View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/freetype/include/freetype-custom-config/ftmodule.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/freetype/include/freetype-custom-config/ftoption.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 47 (30 generated)
drott
Remove outdated comment in build/linux/BUILD.gn
3 years, 9 months ago (2017-03-01 14:38:40 UTC) #8
drott
3 years, 9 months ago (2017-03-01 17:11:53 UTC) #13
bungeman-skia
Skia BUILD change lgtm
3 years, 9 months ago (2017-03-01 18:04:39 UTC) #15
bungeman-chromium
The freetype change lgtm.
3 years, 9 months ago (2017-03-01 18:06:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726873002/40001
3 years, 9 months ago (2017-03-01 19:05:23 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/375812)
3 years, 9 months ago (2017-03-01 19:13:31 UTC) #20
Dirk Pranke
lgtm
3 years, 9 months ago (2017-03-01 19:45:45 UTC) #21
drott
jochen@chromium.org, cpu@chromium.org, brettw@chromium.org: Please review content/shell/BUILD.gn - thanks.
3 years, 9 months ago (2017-03-01 20:04:27 UTC) #23
drott
peter@, mkwst@ or could you help with that? Please review content/shell/BUILD.gn - thank you.
3 years, 9 months ago (2017-03-02 16:27:10 UTC) #29
Mike West
c/s/BUILD.gn LGTM.
3 years, 9 months ago (2017-03-03 05:57:28 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726873002/40001
3 years, 9 months ago (2017-03-06 08:29:02 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/378608)
3 years, 9 months ago (2017-03-06 08:34:26 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726873002/40001
3 years, 9 months ago (2017-03-06 09:10:19 UTC) #38
commit-bot: I haz the power
Failed to apply patch for DEPS: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-06 09:29:19 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726873002/60001
3 years, 9 months ago (2017-03-06 10:18:35 UTC) #43
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/fe896a85ac3ab250cc5cad0e857da7ef32283a11
3 years, 9 months ago (2017-03-06 12:13:39 UTC) #46
jochen (gone - plz use gerrit)
3 years, 9 months ago (2017-03-06 12:58:25 UTC) #47
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698