Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2726853006: Remove GetRootNaN (Closed)

Created:
3 years, 9 months ago by rongjie
Modified:
3 years, 9 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused GetRootNaN BUG=v8:6005 Review-Url: https://codereview.chromium.org/2726853006 Cr-Commit-Position: refs/heads/master@{#43531} Committed: https://chromium.googlesource.com/v8/v8/+/802d367df2b385b08fc8ef7b2c237bf57d78d1bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M src/js/v8natives.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-numbers.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
rongjie
3 years, 9 months ago (2017-03-02 08:25:36 UTC) #2
Benedikt Meurer
LGTM! Thank you!
3 years, 9 months ago (2017-03-02 08:26:26 UTC) #4
Yang
On 2017/03/02 08:26:26, Benedikt Meurer wrote: > LGTM! Thank you! very nice. lgtm.
3 years, 9 months ago (2017-03-02 08:30:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726853006/1
3 years, 9 months ago (2017-03-02 08:39:11 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 09:08:18 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/802d367df2b385b08fc8ef7b2c237bf57d7...

Powered by Google App Engine
This is Rietveld 408576698