Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2726833002:
Rename platform/Widget to platform/FrameViewBase in bindings. (Closed)
|
Created:
3 years, 9 months ago by joelhockey Modified:
3 years, 9 months ago CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRename platform/Widget to platform/FrameViewBase in bindings.
BUG=697351
Review-Url: https://codereview.chromium.org/2726833002
Cr-Commit-Position: refs/heads/master@{#453917}
Committed: https://chromium.googlesource.com/chromium/src/+/84b4215d6c4fa677341ba96dfdfa083a27345b74
Patch Set 1 #Patch Set 2 : Rename platform/Widget to platform/FrameViewBase in bindings. #
Messages
Total messages: 19 (14 generated)
Description was changed from ========== Rename platform/Widget to platform/FrameViewBase in bindings. Part 1 to rename platform/Widget to platform/FrameViewBase. BUG=697351 ========== to ========== Rename platform/Widget to platform/FrameViewBase in bindings. BUG=697351 ==========
The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
joelhockey@chromium.org changed reviewers: + haraken@chromium.org, sashab@chromium.org, slangley@chromium.org
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by joelhockey@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by joelhockey@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488369463665740,
"parent_rev": "ef1fe9bcedcee99abce0a73583db086d15631b1b", "commit_rev":
"84b4215d6c4fa677341ba96dfdfa083a27345b74"}
Message was sent while issue was closed.
Description was changed from ========== Rename platform/Widget to platform/FrameViewBase in bindings. BUG=697351 ========== to ========== Rename platform/Widget to platform/FrameViewBase in bindings. BUG=697351 Review-Url: https://codereview.chromium.org/2726833002 Cr-Commit-Position: refs/heads/master@{#453917} Committed: https://chromium.googlesource.com/chromium/src/+/84b4215d6c4fa677341ba96dfdfa... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/84b4215d6c4fa677341ba96dfdfa... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
