DescriptionMake compositing mode sticky when RenderView is reused in LayoutTests.
The RenderView/Widget and WebViewImpl are reused between layout tests.
But the page Settings object seems to be reset, which means the
forceCompositingMode is turned off between tests, while WebViewImpl
holds onto the m_layerTreeView pointer.
WebViewImpl::enterForceCompositingMode() already has an early out if
the mode is the same as the settings, so have RenderWidget always
call enterForceCompositingMode() so that on LayoutTests other than
the first test (where the RenderWidget is being reused) when
WebViewImpl declares it will begin compositing, we ensure that it
(re-)enters ForceCompositingMode.
This allows us to remove the extra layout() and know that the tests
will never fall out of compositing mode, so we can decide immediately
to do a composited or a software readback. Adjust the WebkitTestRunner
to match these expectations, removing its ability to fallback to
a software readback if a composited readback fails, to guarantee that
in compositing mode the readback is always working instead of hiding
failures.
R=abarth, enne, piman
BUG=370130
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269179
Patch Set 1 #Patch Set 2 : sticky: #Patch Set 3 : sticky: rebase #
Messages
Total messages: 10 (0 generated)
|