Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 272683003: Make compositing mode sticky when RenderView is reused in LayoutTests. (Closed)

Created:
6 years, 7 months ago by danakj
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, jbauman
Visibility:
Public.

Description

Make compositing mode sticky when RenderView is reused in LayoutTests. The RenderView/Widget and WebViewImpl are reused between layout tests. But the page Settings object seems to be reset, which means the forceCompositingMode is turned off between tests, while WebViewImpl holds onto the m_layerTreeView pointer. WebViewImpl::enterForceCompositingMode() already has an early out if the mode is the same as the settings, so have RenderWidget always call enterForceCompositingMode() so that on LayoutTests other than the first test (where the RenderWidget is being reused) when WebViewImpl declares it will begin compositing, we ensure that it (re-)enters ForceCompositingMode. This allows us to remove the extra layout() and know that the tests will never fall out of compositing mode, so we can decide immediately to do a composited or a software readback. Adjust the WebkitTestRunner to match these expectations, removing its ability to fallback to a software readback if a composited readback fails, to guarantee that in compositing mode the readback is always working instead of hiding failures. R=abarth, enne, piman BUG=370130 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269179

Patch Set 1 #

Patch Set 2 : sticky: #

Patch Set 3 : sticky: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -38 lines) Patch
M content/renderer/render_widget.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 chunks +1 line, -6 lines 0 comments Download
M content/shell/renderer/test_runner/WebTestProxy.cpp View 1 2 1 chunk +1 line, -12 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.cc View 2 chunks +10 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
danakj
6 years, 7 months ago (2014-05-07 21:34:32 UTC) #1
danakj
I ran the layout test suite locally and get the same failures with and without ...
6 years, 7 months ago (2014-05-07 21:34:50 UTC) #2
piman
lgtm
6 years, 7 months ago (2014-05-07 21:38:33 UTC) #3
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-05-07 22:36:30 UTC) #4
danakj
blink bots look green CQing.
6 years, 7 months ago (2014-05-07 22:36:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/272683003/40001
6 years, 7 months ago (2014-05-07 22:37:41 UTC) #6
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 7 months ago (2014-05-08 15:42:37 UTC) #7
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-05-08 15:43:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/272683003/40001
6 years, 7 months ago (2014-05-08 15:46:42 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 07:06:38 UTC) #10
Message was sent while issue was closed.
Change committed as 269179

Powered by Google App Engine
This is Rietveld 408576698