Show 'inactive' cookies (fix after https://codereview.chromium.org/2714913002 ).

Show 'inactive' cookies (fix after https://codereview.chromium.org/2714913002 ).
Update default domain for the CookieTable whenever target domain changes.

BUG=697779
Review-Url: https://codereview.chromium.org/2726823004
Cr-Commit-Position: refs/heads/master@{#455599}
Committed: https://chromium.googlesource.com/chromium/src/+/b80db6918ca7234bc688efca0e1716bc3aa2c3b5

[kdzwinel, 2017-03-02 14:10:55]

kdzwinel@gmail.com changed reviewers:
+ phulce@chromium.org

[kdzwinel, 2017-03-02 14:10:56]

PTAL

[phulce, 2017-03-07 23:57:23]

phulce@chromium.org changed reviewers:
+ eostroukhov@chromium.org

[phulce, 2017-03-07 23:57:24]

lgtm, thanks! wish we had moved to let/const...

[kdzwinel, 2017-03-08 06:31:26]

The CQ bit was checked by kdzwinel@gmail.com

[commit-bot: I haz the power, 2017-03-08 06:31:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 06:31:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 06:31:58]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[kdzwinel, 2017-03-08 20:34:20]

On 2017/03/08 at 06:31:58, commit-bot wrote:
> No L-G-T-M from a valid reviewer yet. 
> CQ run can only be started by full committers or once the patch has
> received an L-G-T-M from a full committer.
> Even if an L-G-T-M may have been provided, it was from a non-committer,
> _not_ a full super star committer.
> Committers are members of the group "project-chromium-committers".
> Note that this has nothing to do with OWNERS files.

@phulce haha, yeah if only const was used this error would have been prevented.
TBH though, there are consts used all over DT code (including this CL!),
shouldn't we use it in all new code?

I can't commit this CL ("No L-G-T-M from a valid reviewer"), who should I ask
for a review?

[pfeldman, 2017-03-08 21:17:32]

lgtm

> @phulce haha, yeah if only const was used this error would have been
prevented.
> TBH though, there are consts used all over DT code (including this CL!),
> shouldn't we use it in all new code?

last time I checked, const wasn't optimized in v8, so we stopped using it in
order to avoid confusion.

[kdzwinel, 2017-03-08 21:27:06]

The CQ bit was checked by kdzwinel@gmail.com

[commit-bot: I haz the power, 2017-03-08 21:27:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kdzwinel, 2017-03-08 21:35:52]

On 2017/03/08 at 21:17:32, pfeldman wrote:
> lgtm

Thank you!

> > @phulce haha, yeah if only const was used this error would have been
prevented.
> > TBH though, there are consts used all over DT code (including this CL!),
> > shouldn't we use it in all new code?
> 
> last time I checked, const wasn't optimized in v8, so we stopped using it in
order to avoid confusion.

Good to know. I've left a comment in the contribution guide where it says that
consts can be used (
https://docs.google.com/document/d/1WNF-KqRSzPLUUfZqQG5AFeU_Ll8TfWYcJasa_XGf7...
)

[commit-bot: I haz the power, 2017-03-08 23:51:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489008426027780, "parent_rev":
"bc81898122086cf8a510c854583eefee34c1f022", "commit_rev":
"b80db6918ca7234bc688efca0e1716bc3aa2c3b5"}

[commit-bot: I haz the power, 2017-03-08 23:52:56]

Description was changed from

==========
Show 'inactive' cookies (fix after https://codereview.chromium.org/2714913002 ).
Update default domain for the CookieTable whenever target domain changes.

BUG=697779
==========

to

==========
Show 'inactive' cookies (fix after https://codereview.chromium.org/2714913002 ).
Update default domain for the CookieTable whenever target domain changes.

BUG=697779

Review-Url: https://codereview.chromium.org/2726823004
Cr-Commit-Position: refs/heads/master@{#455599}
Committed:
https://chromium.googlesource.com/chromium/src/+/b80db6918ca7234bc688efca0e17...
==========

[commit-bot: I haz the power, 2017-03-08 23:52:58]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b80db6918ca7234bc688efca0e17...