Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2726773003: Reland: Make popup notification active on being clicked (Closed)

Created:
3 years, 9 months ago by yoshiki
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, Peter Beverloo, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Make popup notification active on being clicked The original patch was committed (crrev.com/453944) but was reverted (crrev.com/453947). This patch is a reland with exporting ToastContentsView. This notification adds the code to make a notification activatable and active. Currently this code is called when user clicks a popup notification (aka. toast), and fixes the issue that an EditText on toast doesn't work. BUG=b/35302601 TEST=Direct Reply on Toast works TBR=oshima@chromium.org, dewittj@chromium.org Review-Url: https://codereview.chromium.org/2726773003 Cr-Commit-Position: refs/heads/master@{#453985} Committed: https://chromium.googlesource.com/chromium/src/+/a373e4c28e327db99a4069f42c3d2cf5413863e0

Patch Set 1 : Original Patch (once committed but reverted) #

Patch Set 2 : Relanded Patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -3 lines) Patch
M ui/arc/notification/arc_custom_notification_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_view.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M ui/message_center/views/toast_contents_view.h View 1 4 chunks +11 lines, -3 lines 0 comments Download
M ui/message_center/views/toast_contents_view.cc View 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726773003/20001
3 years, 9 months ago (2017-03-01 18:58:22 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 19:05:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a373e4c28e327db99a4069f42c3d...

Powered by Google App Engine
This is Rietveld 408576698