gpu: Do not call MakeCurrent in wait sync token callback.

gpu: Do not call MakeCurrent in wait sync token callback.

The wait sync token completion callback is called while commands are
being processed in the releasing context. Therefore, it is not safe to
call MakeCurrent on the waiting context and pull texture updates from
MailboxManagerSync. Moreoever, the wait sync token command is executed
again when the context is scheduled, and PullTextureUpdates will be
called there.

R=jbauman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2726743002
Cr-Commit-Position: refs/heads/master@{#454728}
Committed: https://chromium.googlesource.com/chromium/src/+/6125ed888b761ec02660821245615da02587008c

[sunnyps, 2017-02-28 23:50:46]

Description was changed from

==========
gpu: Do not call MakeCurrent in wait sync token callback.

The wait sync token completion callback is called while commands are
being processed in the releasing context. Therefore, it is not safe to
call MakeCurrent on the waiting context and pull texture updates from
MailboxManagerSync. Moreoever, the wait sync token command is executed
again when the context is scheduled, and PullTextureUpdates will be
called there.

R=jbauman@chromium.org
==========

to

==========
gpu: Do not call MakeCurrent in wait sync token callback.

The wait sync token completion callback is called while commands are
being processed in the releasing context. Therefore, it is not safe to
call MakeCurrent on the waiting context and pull texture updates from
MailboxManagerSync. Moreoever, the wait sync token command is executed
again when the context is scheduled, and PullTextureUpdates will be
called there.

R=jbauman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[sunnyps, 2017-02-28 23:52:45]

The CQ bit was checked by sunnyps@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 23:53:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunnyps, 2017-02-28 23:54:35]

This based on top of https://codereview.chromium.org/2722883002/

PS 3 contains the changes for this CL.

PTAL

[commit-bot: I haz the power, 2017-03-01 00:23:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 00:23:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbauman, 2017-03-03 22:23:55]

lgtm

[sunnyps, 2017-03-03 23:41:33]

The CQ bit was checked by sunnyps@chromium.org

[sunnyps, 2017-03-03 23:41:39]

The CQ bit was unchecked by sunnyps@chromium.org

[sunnyps, 2017-03-03 23:57:29]

Description was changed from

==========
gpu: Do not call MakeCurrent in wait sync token callback.

The wait sync token completion callback is called while commands are
being processed in the releasing context. Therefore, it is not safe to
call MakeCurrent on the waiting context and pull texture updates from
MailboxManagerSync. Moreoever, the wait sync token command is executed
again when the context is scheduled, and PullTextureUpdates will be
called there.

R=jbauman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu: Do not call MakeCurrent in wait sync token callback.

The wait sync token completion callback is called while commands are
being processed in the releasing context. Therefore, it is not safe to
call MakeCurrent on the waiting context and pull texture updates from
MailboxManagerSync. Moreoever, the wait sync token command is executed
again when the context is scheduled, and PullTextureUpdates will be
called there.

R=jbauman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[sunnyps, 2017-03-03 23:57:38]

The CQ bit was checked by sunnyps@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 23:57:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunnyps, 2017-03-03 23:57:58]

The CQ bit was checked by sunnyps@chromium.org

[sunnyps, 2017-03-03 23:57:58]

The patchset sent to the CQ was uploaded after l-g-t-m from jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/2726743002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-03 23:58:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 00:51:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488585478042560,
"parent_rev": "d6c15bfcf01549bf92de247886214b872758b387", "commit_rev":
"6125ed888b761ec02660821245615da02587008c"}

[commit-bot: I haz the power, 2017-03-04 00:52:04]

Description was changed from

==========
gpu: Do not call MakeCurrent in wait sync token callback.

The wait sync token completion callback is called while commands are
being processed in the releasing context. Therefore, it is not safe to
call MakeCurrent on the waiting context and pull texture updates from
MailboxManagerSync. Moreoever, the wait sync token command is executed
again when the context is scheduled, and PullTextureUpdates will be
called there.

R=jbauman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu: Do not call MakeCurrent in wait sync token callback.

The wait sync token completion callback is called while commands are
being processed in the releasing context. Therefore, it is not safe to
call MakeCurrent on the waiting context and pull texture updates from
MailboxManagerSync. Moreoever, the wait sync token command is executed
again when the context is scheduled, and PullTextureUpdates will be
called there.

R=jbauman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2726743002
Cr-Commit-Position: refs/heads/master@{#454728}
Committed:
https://chromium.googlesource.com/chromium/src/+/6125ed888b761ec0266082124561...
==========

[commit-bot: I haz the power, 2017-03-04 00:52:09]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6125ed888b761ec0266082124561...