Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2726643002: [Contextual Search] Use panel location to determine test touch target (Closed)

Created:
3 years, 9 months ago by Theresa
Modified:
3 years, 9 months ago
Reviewers:
Donn Denman
CC:
chromium-reviews, twellington+watch_chromium.org, donnd+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Contextual Search] Use panel location to determine test touch target BUG=697055 Review-Url: https://codereview.chromium.org/2726643002 Cr-Commit-Position: refs/heads/master@{#453725} Committed: https://chromium.googlesource.com/chromium/src/+/af45f47f94de96e49d4e93ad2dfbe806b9a3e3b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 6 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Theresa
ptal - I've run all tests in portrait and landscape on a Nexus 9 and ...
3 years, 9 months ago (2017-02-28 19:13:04 UTC) #4
Donn Denman
LGTM Thanks for quickly chasing this down and fixing Theresa!
3 years, 9 months ago (2017-02-28 20:01:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726643002/1
3 years, 9 months ago (2017-02-28 22:10:41 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 22:18:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/af45f47f94de96e49d4e93ad2dfb...

Powered by Google App Engine
This is Rietveld 408576698