Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2726613002:
Fix ensureInitialized() to try if the previous attempt failed (Closed)
|
Created:
3 years, 9 months ago by kapishnikov Modified:
3 years, 9 months ago CC:
chromium-reviews, cbentzel+watch_chromium.org, agrieve+watch_chromium.org, net-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix ensureInitialized() to retry if the previous attempts failed
If ensureInitialized() fails the first time, the second
call to it will do nothing and return right away. This change makes sure
that if the first call failed, the second one retries the initialization.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
BUG=697153
Review-Url: https://codereview.chromium.org/2726613002
Cr-Commit-Position: refs/heads/master@{#453681}
Committed: https://chromium.googlesource.com/chromium/src/+/fdf249c81c06c4e679f4f1bedd1c5c030da029fa
Patch Set 1 #
Total comments: 1
Patch Set 2 : Removed redundant if statement #Messages
Total messages: 19 (12 generated)
Description was changed from ========== Fix ensureInitialized() to try if the previous attempt failed If ensureInitialized() fails the first time it is called, the second call to it will do nothing and return right away. This change makes sure that if the first time fails, the second time will try to initialize again. ========== to ========== Fix ensureInitialized() to try if the previous attempt failed If ensureInitialized() fails the first time it is called, the second call to it will do nothing and return right away. This change makes sure that if the first time fails, the second time will try to initialize again. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
Description was changed from ========== Fix ensureInitialized() to try if the previous attempt failed If ensureInitialized() fails the first time it is called, the second call to it will do nothing and return right away. This change makes sure that if the first time fails, the second time will try to initialize again. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== Fix ensureInitialized() to retry if the previous attempts failed If ensureInitialized() fails the first time, the second call to it will do nothing and return right away. This change makes sure that if the first call failed, the second one retries the initialization. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
kapishnikov@chromium.org changed reviewers: + mef@chromium.org, pauljensen@chromium.org, xunjieli@chromium.org
PTAL
lgtm https://codereview.chromium.org/2726613002/diff/1/components/cronet/android/j... File components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java (right): https://codereview.chromium.org/2726613002/diff/1/components/cronet/android/j... components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java:41: } nit: remove if-statement as it's redundant with if statements below and introduces the requirment that it be kept in sync with any other code that could be added below the last if-statement.
The CQ bit was checked by kapishnikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm. could you file a crbug with a brief description of the motivation and link it here?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix ensureInitialized() to retry if the previous attempts failed If ensureInitialized() fails the first time, the second call to it will do nothing and return right away. This change makes sure that if the first call failed, the second one retries the initialization. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== Fix ensureInitialized() to retry if the previous attempts failed If ensureInitialized() fails the first time, the second call to it will do nothing and return right away. This change makes sure that if the first call failed, the second one retries the initialization. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG=697153 ==========
On 2017/02/28 19:07:52, pauljensen wrote: > lgtm > > https://codereview.chromium.org/2726613002/diff/1/components/cronet/android/j... > File > components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java > (right): > > https://codereview.chromium.org/2726613002/diff/1/components/cronet/android/j... > components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java:41: > } > nit: remove if-statement as it's redundant with if statements below and > introduces the requirment that it be kept in sync with any other code that could > be added below the last if-statement. Done.
On 2017/02/28 19:27:10, xunjieli wrote: > lgtm. > > could you file a crbug with a brief description of the motivation and link it > here? Done.
The CQ bit was checked by kapishnikov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pauljensen@chromium.org Link to the patchset: https://codereview.chromium.org/2726613002/#ps20001 (title: "Removed redundant if statement")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488311928311250,
"parent_rev": "ba3a4d8ad97649db9ce47979a18f93fd07b0499e", "commit_rev":
"fdf249c81c06c4e679f4f1bedd1c5c030da029fa"}
Message was sent while issue was closed.
Description was changed from ========== Fix ensureInitialized() to retry if the previous attempts failed If ensureInitialized() fails the first time, the second call to it will do nothing and return right away. This change makes sure that if the first call failed, the second one retries the initialization. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG=697153 ========== to ========== Fix ensureInitialized() to retry if the previous attempts failed If ensureInitialized() fails the first time, the second call to it will do nothing and return right away. This change makes sure that if the first call failed, the second one retries the initialization. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG=697153 Review-Url: https://codereview.chromium.org/2726613002 Cr-Commit-Position: refs/heads/master@{#453681} Committed: https://chromium.googlesource.com/chromium/src/+/fdf249c81c06c4e679f4f1bedd1c... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/fdf249c81c06c4e679f4f1bedd1c... |
