Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2726603003: mus+ash: Copy parts of ScreenAsh to ScreenMus. (Closed)

Created:
3 years, 9 months ago by Elliot Glaysher
Modified:
3 years, 9 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus+ash: Copy parts of ScreenAsh to ScreenMus. This copies the implementation of ScreenAsh::IsWindowUnderCursor() and ScreenAsh::GetWindowAtScreenPoint() to ScreenMus; the rest can't be consolidated because of usage of the display manager, which is mostly unimplemented on mus+ash. BUG=671408 Review-Url: https://codereview.chromium.org/2726603003 Cr-Commit-Position: refs/heads/master@{#454113} Committed: https://chromium.googlesource.com/chromium/src/+/860df320f00a381f2a743d14a7fc095130428255

Patch Set 1 #

Patch Set 2 : Add unit tests. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -0 lines) Patch
M ash/mus/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/mus/screen_mus.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/mus/screen_mus.cc View 2 chunks +20 lines, -0 lines 0 comments Download
A ash/mus/screen_mus_unittest.cc View 1 1 chunk +53 lines, -0 lines 1 comment Download

Messages

Total messages: 16 (12 generated)
Elliot Glaysher
3 years, 9 months ago (2017-03-01 23:14:39 UTC) #10
James Cook
LGTM https://codereview.chromium.org/2726603003/diff/20001/ash/mus/screen_mus_unittest.cc File ash/mus/screen_mus_unittest.cc (right): https://codereview.chromium.org/2726603003/diff/20001/ash/mus/screen_mus_unittest.cc#newcode50 ash/mus/screen_mus_unittest.cc:50: } Thanks for adding test coverage.
3 years, 9 months ago (2017-03-02 00:08:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726603003/20001
3 years, 9 months ago (2017-03-02 00:10:21 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 00:16:58 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/860df320f00a381f2a743d14a7fc...

Powered by Google App Engine
This is Rietveld 408576698