Add a console message when a permission is embargoed due to repeated dismissals.

Add a console message when a permission is embargoed due to repeated dismissals.

This CL adds a console log to help inform developers if they have had
their permission blocked due to repeated dismissals.

BUG=679877
Review-Url: https://codereview.chromium.org/2726493002
Cr-Commit-Position: refs/heads/master@{#453826}
Committed: https://chromium.googlesource.com/chromium/src/+/d9fb73c14f0a2708be39521df7fa977cf902a049

[dominickn, 2017-02-28 23:20:09]

dominickn@chromium.org changed reviewers:
+ raymes@chromium.org

[dominickn, 2017-02-28 23:20:10]

PTAL, thanks!

[raymes, 2017-02-28 23:44:38]

https://codereview.chromium.org/2726493002/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_context_base.cc (right):

https://codereview.chromium.org/2726493002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_context_base.cc:120: .c_str()));
nit: it would be nice to get some of this logging logic out of the main flow of
the permission logic. Could we have a helper function which does logging? e.g.

LogPermissionBlockedMessage(WebContents* web_contents, const std::string&
message, ContentSettingsType type)?

We may also want to make the strings into constants.

[dominickn, 2017-02-28 23:55:53]

Patchset #2 (id:20001) has been deleted

[dominickn, 2017-03-01 02:28:45]

Thanks!

https://codereview.chromium.org/2726493002/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_context_base.cc (right):

https://codereview.chromium.org/2726493002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_context_base.cc:120: .c_str()));
On 2017/02/28 23:44:38, raymes wrote:
> nit: it would be nice to get some of this logging logic out of the main flow
of
> the permission logic. Could we have a helper function which does logging? e.g.
> 
> LogPermissionBlockedMessage(WebContents* web_contents, const std::string&
> message, ContentSettingsType type)?
> 
> We may also want to make the strings into constants.

Done.

[raymes, 2017-03-01 02:31:41]

lgtm, thanks for the cleanup!

[dominickn, 2017-03-01 02:33:00]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 02:33:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 03:26:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 03:26:21]

Dry run: This issue passed the CQ dry run.

[dominickn, 2017-03-01 03:29:51]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2017-03-01 03:30:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 03:34:27]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488338991507760,
"parent_rev": "b8721b0aa68a020f092aede9b18b33389ed24e8f", "commit_rev":
"d9fb73c14f0a2708be39521df7fa977cf902a049"}

[commit-bot: I haz the power, 2017-03-01 03:35:03]

Description was changed from

==========
Add a console message when a permission is embargoed due to repeated dismissals.

This CL adds a console log to help inform developers if they have had
their permission blocked due to repeated dismissals.

BUG=679877
==========

to

==========
Add a console message when a permission is embargoed due to repeated dismissals.

This CL adds a console log to help inform developers if they have had
their permission blocked due to repeated dismissals.

BUG=679877

Review-Url: https://codereview.chromium.org/2726493002
Cr-Commit-Position: refs/heads/master@{#453826}
Committed:
https://chromium.googlesource.com/chromium/src/+/d9fb73c14f0a2708be39521df7fa...
==========

[commit-bot: I haz the power, 2017-03-01 03:35:04]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d9fb73c14f0a2708be39521df7fa...