Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2726493002: Add a console message when a permission is embargoed due to repeated dismissals. (Closed)

Created:
3 years, 9 months ago by dominickn
Modified:
3 years, 9 months ago
Reviewers:
raymes
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, raymes+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a console message when a permission is embargoed due to repeated dismissals. This CL adds a console log to help inform developers if they have had their permission blocked due to repeated dismissals. BUG=679877 Review-Url: https://codereview.chromium.org/2726493002 Cr-Commit-Position: refs/heads/master@{#453826} Committed: https://chromium.googlesource.com/chromium/src/+/d9fb73c14f0a2708be39521df7fa977cf902a049

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -12 lines) Patch
M chrome/browser/permissions/permission_context_base.cc View 1 3 chunks +35 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
dominickn
PTAL, thanks!
3 years, 9 months ago (2017-02-28 23:20:10 UTC) #2
raymes
https://codereview.chromium.org/2726493002/diff/1/chrome/browser/permissions/permission_context_base.cc File chrome/browser/permissions/permission_context_base.cc (right): https://codereview.chromium.org/2726493002/diff/1/chrome/browser/permissions/permission_context_base.cc#newcode120 chrome/browser/permissions/permission_context_base.cc:120: .c_str())); nit: it would be nice to get some ...
3 years, 9 months ago (2017-02-28 23:44:38 UTC) #3
dominickn
Thanks! https://codereview.chromium.org/2726493002/diff/1/chrome/browser/permissions/permission_context_base.cc File chrome/browser/permissions/permission_context_base.cc (right): https://codereview.chromium.org/2726493002/diff/1/chrome/browser/permissions/permission_context_base.cc#newcode120 chrome/browser/permissions/permission_context_base.cc:120: .c_str())); On 2017/02/28 23:44:38, raymes wrote: > nit: ...
3 years, 9 months ago (2017-03-01 02:28:45 UTC) #5
raymes
lgtm, thanks for the cleanup!
3 years, 9 months ago (2017-03-01 02:31:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726493002/40001
3 years, 9 months ago (2017-03-01 03:30:15 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 03:35:04 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d9fb73c14f0a2708be39521df7fa...

Powered by Google App Engine
This is Rietveld 408576698