Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2726483002: MD Settings: fix some dynamically bound aria-labels (Closed)

Created:
3 years, 9 months ago by Dan Beam
Modified:
3 years, 9 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix some dynamically bound aria-labels This was changing this.ariaLabel = text; instead of this.setAttribute('aria-label', text); TBR=hcarmona@chromium.org BUG=686309, 686327, 686330 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2726483002 Cr-Commit-Position: refs/heads/master@{#453526} Committed: https://chromium.googlesource.com/chromium/src/+/30439e06b055ad586887a8b45de61f5655eb7574

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/resources/settings/about_page/about_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/device_page/device_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/search_page/search_page.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_list.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
Dan Beam
3 years, 9 months ago (2017-02-28 05:27:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726483002/1
3 years, 9 months ago (2017-02-28 05:28:14 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 06:35:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/30439e06b055ad586887a8b45de6...

Powered by Google App Engine
This is Rietveld 408576698