Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2963)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java

Issue 2726423002: Fix DownloadNotificationService foreground state (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java b/chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java
index 28284a5aa6b6e7661f0ab8107d3560330dcc747c..b57ae120e3bab0938692e86c330b91ce52088228 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java
@@ -39,6 +39,20 @@ public class MockDownloadNotificationService extends DownloadNotificationService
}
@Override
+ boolean hasDownloadNotifications(Integer notificationIdToIgnore) {
+ // Cancelling notifications here is synchronous, so we don't really have to worry about
+ // {@code notificationIdToIgnore}, but address it properly anyway.
+ if (mNotificationIds.size() == 1 && notificationIdToIgnore != null) {
+ return !mNotificationIds.contains(notificationIdToIgnore);
+ }
+
+ return !mNotificationIds.isEmpty();
+ }
+
+ @Override
+ void cancelSummaryNotification() {}
+
+ @Override
void updateNotification(int id, Notification notification) {
if (!mNotificationIds.contains(id)) {
mNotificationIds.add(id);

Powered by Google App Engine
This is Rietveld 408576698