chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java - Issue 2726423002: Fix DownloadNotificationService foreground state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java

Issue 2726423002: Fix DownloadNotificationService foreground state (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java b/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java

index 7e5d29ab6327fea0892be23f86dbe334f065a1db..768ca2e6304ee3711bbca1d1b7c8156b7d005353 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java

@@ -298,7 +298,9 @@ public class SystemDownloadNotifier implements DownloadNotifier, Observer {

assert false;

}

- if (mBoundService != null) mBoundService.hideSummaryNotificationIfNecessary();

+ // Don't need to expose the notification id to ignore. Cancel will automatically call this

+ // method as well and pass it in.

+ if (mBoundService != null) mBoundService.hideSummaryNotificationIfNecessary(null);

if (autoRelease) unbindServiceIfNeeded();

}