Reland - Omnibox - Zero Suggest - Log When/Whether Contextual Search is Possible

Reland - Omnibox - Zero Suggest - Log When/Whether Contextual Search is Possible

Reland
https://codereview.chromium.org/2724303002
after changing one static initializer from a std::string to a const char[].

See original changelist description for more details:
---
This will allow us to estimate the "headroom", i.e., how many people and
how many focus events could we actually help with contextual suggestions.

No functional changes (intended).

TEST=using about:histograms
---

TBR=pkasting
TBR=isherman

BUG=696077
Review-Url: https://codereview.chromium.org/2726413002
Cr-Commit-Position: refs/heads/master@{#454676}
Committed: https://chromium.googlesource.com/chromium/src/+/3d89cdcd61c6b95d514e2c9ed86e929483e0cc76

[Mark P, 2017-03-03 19:04:06]

Description was changed from

==========
Reland - Omnibox - Zero Suggest - Log When/Whether Contextual Search is Possible

Reland
https://codereview.chromium.org/2724303002
after changing one static initializer from a std::string to a const char[].

See original changelist description for more details:
---
This will allow us to estimate the "headroom", i.e., how many people and
how many focus events could we actually help with contextual suggestions.

No functional changes (intended).

TEST=using about:histograms
---

BUG=696077
==========

to

==========
Reland - Omnibox - Zero Suggest - Log When/Whether Contextual Search is Possible

Reland
https://codereview.chromium.org/2724303002
after changing one static initializer from a std::string to a const char[].

See original changelist description for more details:
---
This will allow us to estimate the "headroom", i.e., how many people and
how many focus events could we actually help with contextual suggestions.

No functional changes (intended).

TEST=using about:histograms
---

TBR=pkasting
TBR=isherman

BUG=696077
==========

[Mark P, 2017-03-03 19:05:24]

The CQ bit was checked by mpearson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 19:05:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark P, 2017-03-03 19:05:55]

mpearson@chromium.org changed reviewers:
+ pkasting@chromium.org

[Mark P, 2017-03-03 19:05:55]

Hey Peter, take a look at this one-line change if you want before I land this.

--mark

[Peter Kasting, 2017-03-03 20:09:11]

On 2017/03/03 19:05:55, Mark P wrote:
> Hey Peter, take a look at this one-line change if you want before I land this.

What's the one-line change?  You didn't upload the original patch set to diff
against.

[commit-bot: I haz the power, 2017-03-03 20:10:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 20:10:37]

Dry run: This issue passed the CQ dry run.

[Mark P, 2017-03-03 20:14:29]

https://codereview.chromium.org/2726413002/diff/1/components/omnibox/browser/...
File components/omnibox/browser/zero_suggest_provider.cc (right):

https://codereview.chromium.org/2726413002/diff/1/components/omnibox/browser/...
components/omnibox/browser/zero_suggest_provider.cc:84: const char
kArbitraryInsecureUrlString[] = "http://www.google.com/";
This line changed from
std::string kArbitraryInsecureUrlString = "http://www.google.com/";
to its current state.

[Peter Kasting, 2017-03-03 20:21:56]

LGTM

https://codereview.chromium.org/2726413002/diff/1/components/omnibox/browser/...
File components/omnibox/browser/zero_suggest_provider.cc (right):

https://codereview.chromium.org/2726413002/diff/1/components/omnibox/browser/...
components/omnibox/browser/zero_suggest_provider.cc:84: const char
kArbitraryInsecureUrlString[] = "http://www.google.com/";
On 2017/03/03 20:14:29, Mark P wrote:
> This line changed from
> std::string kArbitraryInsecureUrlString = "http://www.google.com/";
> to its current state.

Cool.

Prefer constexpr here.

[Mark P, 2017-03-03 21:10:07]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2017-03-03 21:10:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 21:15:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488575407609900, "parent_rev":
"1a9f983b18d21da00d0e64647a0adbd91d7fbbb5", "commit_rev":
"3d89cdcd61c6b95d514e2c9ed86e929483e0cc76"}

[commit-bot: I haz the power, 2017-03-03 21:16:55]

Description was changed from

==========
Reland - Omnibox - Zero Suggest - Log When/Whether Contextual Search is Possible

Reland
https://codereview.chromium.org/2724303002
after changing one static initializer from a std::string to a const char[].

See original changelist description for more details:
---
This will allow us to estimate the "headroom", i.e., how many people and
how many focus events could we actually help with contextual suggestions.

No functional changes (intended).

TEST=using about:histograms
---

TBR=pkasting
TBR=isherman

BUG=696077
==========

to

==========
Reland - Omnibox - Zero Suggest - Log When/Whether Contextual Search is Possible

Reland
https://codereview.chromium.org/2724303002
after changing one static initializer from a std::string to a const char[].

See original changelist description for more details:
---
This will allow us to estimate the "headroom", i.e., how many people and
how many focus events could we actually help with contextual suggestions.

No functional changes (intended).

TEST=using about:histograms
---

TBR=pkasting
TBR=isherman

BUG=696077

Review-Url: https://codereview.chromium.org/2726413002
Cr-Commit-Position: refs/heads/master@{#454676}
Committed:
https://chromium.googlesource.com/chromium/src/+/3d89cdcd61c6b95d514e2c9ed86e...
==========

[commit-bot: I haz the power, 2017-03-03 21:16:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3d89cdcd61c6b95d514e2c9ed86e...

[Mark P, 2017-03-03 21:21:37]

On 2017/03/03 21:16:56, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/3d89cdcd61c6b95d514e2c9ed86e...

By the way, I'll handle the comment in the followup changelist.

--mark

[Mark P, 2017-03-03 22:12:40]

Did cleanup in
https://codereview.chromium.org/2725333004/

--mark

https://codereview.chromium.org/2726413002/diff/1/components/omnibox/browser/...
File components/omnibox/browser/zero_suggest_provider.cc (right):

https://codereview.chromium.org/2726413002/diff/1/components/omnibox/browser/...
components/omnibox/browser/zero_suggest_provider.cc:84: const char
kArbitraryInsecureUrlString[] = "http://www.google.com/";
On 2017/03/03 20:21:55, Peter Kasting wrote:
> On 2017/03/03 20:14:29, Mark P wrote:
> > This line changed from
> > std::string kArbitraryInsecureUrlString = "http://www.google.com/";
> > to its current state.
> 
> Cool.
> 
> Prefer constexpr here.

Done.