WebUI: Split unpack_pak functionality to its own GN action.

WebUI: Split unpack_pak functionality to its own GN action.

This is a preparatory step for splitting MD Settings to a main
and a lazy module.

BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2726403003
Cr-Commit-Position: refs/heads/master@{#455966}
Committed: https://chromium.googlesource.com/chromium/src/+/17018ae26c0cb9c21e76f9e6040d0583b78f6b93

[dpapad, 2017-03-03 23:48:55]

Description was changed from

==========
WebUI: Split unpack_pak functionality to its own GN action.

BUG=597347
==========

to

==========
WebUI: Split unpack_pak functionality to its own GN action.

BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-03-03 23:55:21]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 23:55:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 01:04:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-04 01:04:32]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-03-04 01:12:54]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-04 01:13:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 02:10:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-04 02:10:37]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-03-10 00:07:02]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[dpapad, 2017-03-10 00:07:43]

Description was changed from

==========
WebUI: Split unpack_pak functionality to its own GN action.

BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
WebUI: Split unpack_pak functionality to its own GN action.

This is a preparatory step for splitting MD Settings to a main
and a lazy module.

BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-03-10 00:07:43]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[commit-bot: I haz the power, 2017-03-10 00:07:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-03-10 00:10:33]

lgtm

https://codereview.chromium.org/2726403003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/BUILD.gn (right):

https://codereview.chromium.org/2726403003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/BUILD.gn:7: unpack_pak_folder =
"settings_resources.unpak"
nit: unpack_pak -> unpak everywhere? ;)

https://codereview.chromium.org/2726403003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/unpack_pak.py (right):

https://codereview.chromium.org/2726403003/diff/60001/chrome/browser/resource...
chrome/browser/resources/unpack_pak.py:55: 
\n\n

https://codereview.chromium.org/2726403003/diff/60001/chrome/browser/resource...
chrome/browser/resources/unpack_pak.py:63: 
\n\n

[dpapad, 2017-03-10 01:42:31]

https://codereview.chromium.org/2726403003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/BUILD.gn (right):

https://codereview.chromium.org/2726403003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/BUILD.gn:7: unpack_pak_folder =
"settings_resources.unpak"
On 2017/03/10 at 00:10:32, Dan Beam wrote:
> nit: unpack_pak -> unpak everywhere? ;)

Done (except from renaming unpack_pak.py itself).

https://codereview.chromium.org/2726403003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/unpack_pak.py (right):

https://codereview.chromium.org/2726403003/diff/60001/chrome/browser/resource...
chrome/browser/resources/unpack_pak.py:55: 
On 2017/03/10 at 00:10:32, Dan Beam wrote:
> \n\n

Done.

https://codereview.chromium.org/2726403003/diff/60001/chrome/browser/resource...
chrome/browser/resources/unpack_pak.py:63: 
On 2017/03/10 at 00:10:32, Dan Beam wrote:
> \n\n

Done.

[dpapad, 2017-03-10 01:44:11]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2017-03-10 01:44:11]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2726403003/#ps80001
(title: "Address comments.")

[commit-bot: I haz the power, 2017-03-10 01:44:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 02:54:44]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489110251403190,
"parent_rev": "0b46f3a24bf36d7cf91ec2d88132d15563b85d0e", "commit_rev":
"17018ae26c0cb9c21e76f9e6040d0583b78f6b93"}

[commit-bot: I haz the power, 2017-03-10 02:55:22]

Description was changed from

==========
WebUI: Split unpack_pak functionality to its own GN action.

This is a preparatory step for splitting MD Settings to a main
and a lazy module.

BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
WebUI: Split unpack_pak functionality to its own GN action.

This is a preparatory step for splitting MD Settings to a main
and a lazy module.

BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2726403003
Cr-Commit-Position: refs/heads/master@{#455966}
Committed:
https://chromium.googlesource.com/chromium/src/+/17018ae26c0cb9c21e76f9e6040d...
==========

[commit-bot: I haz the power, 2017-03-10 02:55:23]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/17018ae26c0cb9c21e76f9e6040d...

[Nico, 2017-03-22 22:09:05]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-03-22 22:09:06]

https://codereview.chromium.org/2726403003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/vulcanize.gni (right):

https://codereview.chromium.org/2726403003/diff/80001/chrome/browser/resource...
chrome/browser/resources/vulcanize.gni:111:
"$target_gen_dir/${invoker.out_folder}",
Listing directories as outputs isn't great, since mtimes on directories are a
bit unpredictable (In particular, if a file in a subdirectory is touched, it
won't update the parent directories time stamp). Can you use a stamp file as
output instead?

[dpapad, 2017-03-22 22:39:27]

On 2017/03/22 at 22:09:06, thakis wrote:
>
https://codereview.chromium.org/2726403003/diff/80001/chrome/browser/resource...
> File chrome/browser/resources/vulcanize.gni (right):
> 
>
https://codereview.chromium.org/2726403003/diff/80001/chrome/browser/resource...
> chrome/browser/resources/vulcanize.gni:111:
"$target_gen_dir/${invoker.out_folder}",
> Listing directories as outputs isn't great, since mtimes on directories are a
bit unpredictable (In particular, if a file in a subdirectory is touched, it
won't update the parent directories time stamp). Can you use a stamp file as
output instead?

I'll look into it. Assuming that the stamp file you are referring to already
exists somewhere and I just need to change the declared output. If you can point
me to a similar example it would be helpful. Thanks.