Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2726283004: Revert "Omnibox - Zero Suggest - Log When/Whether Contextual Search is Possible" (Closed)

Created:
3 years, 9 months ago by alph
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Omnibox - Zero Suggest - Log When/Whether Contextual Search is Possible" This reverts commit 7e53e414ae9db0bcb229b4b63053f6748fa93681. Broke Linux build sizes step. https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/34352 BUG=696077 NOTRY=true TBR=mpearson@chromium.org,pkasting@chromium.org,isherman@chromium.org Review-Url: https://codereview.chromium.org/2726283004 Cr-Commit-Position: refs/heads/master@{#454536} Committed: https://chromium.googlesource.com/chromium/src/+/40a050ad605fa870a7f7c5da8c3b0f78bfb4d58f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -155 lines) Patch
M components/omnibox/browser/zero_suggest_provider.h View 1 chunk +0 lines, -6 lines 0 comments Download
M components/omnibox/browser/zero_suggest_provider.cc View 7 chunks +24 lines, -81 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -68 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726283004/1
3 years, 9 months ago (2017-03-03 07:16:32 UTC) #2
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 07:22:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/40a050ad605fa870a7f7c5da8c3b...

Powered by Google App Engine
This is Rietveld 408576698