Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2726153003:
[typedarrays] No callbacks for fast sorting of integer typed arrays (Closed)
|
Created:
3 years, 9 months ago by Choongwoo Han Modified:
3 years, 9 months ago Reviewers:
Benedikt Meurer CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[typedarrays] No callbacks for fast sorting of integer typed arrays
- No callbacks for std::sort of integer typed arrays when user-defined
comparison is not given
- Use template function, instead of macro, for comparison function
- Do not sort if the array size is less than or equal to 1
BUG=v8:5953
Review-Url: https://codereview.chromium.org/2726153003
Cr-Commit-Position: refs/heads/master@{#43565}
Committed: https://chromium.googlesource.com/v8/v8/+/a3709d47e65885ba1dbae086dd8452cbf3cbe899
Patch Set 1 #Patch Set 2 : for windows #Patch Set 3 : static casting to double #Messages
Total messages: 22 (18 generated)
Description was changed from ========== [typedarrays] No callbacks for fast sorting of integer typed arrays - No callbacks for std::sort of integer typed arrays when user-defined comparison is not given - Use template function instead of macro for comparison function - Do not sort if the array size is less than or equal to 1 BUG=v8:5953 ========== to ========== [typedarrays] No callbacks for fast sorting of integer typed arrays - No callbacks for std::sort of integer typed arrays when user-defined comparison is not given - Use template function, instead of macro, for comparison function - Do not sort if the array size is less than or equal to 1 BUG=v8:5953 ==========
cwhan.tunz@gmail.com changed reviewers: + bmeurer@chromium.org
PTAL
LGTM! Thanks
The CQ bit was checked by cwhan.tunz@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/23492) v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...) v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/23580)
The CQ bit was checked by cwhan.tunz@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/23494) v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...) v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...) v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/23582)
The CQ bit was checked by cwhan.tunz@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by cwhan.tunz@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org Link to the patchset: https://codereview.chromium.org/2726153003/#ps40001 (title: "static casting to double")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488517103129620,
"parent_rev": "092222c791fc4eb6e7cd2663226110e6937be98a", "commit_rev":
"a3709d47e65885ba1dbae086dd8452cbf3cbe899"}
Message was sent while issue was closed.
Description was changed from ========== [typedarrays] No callbacks for fast sorting of integer typed arrays - No callbacks for std::sort of integer typed arrays when user-defined comparison is not given - Use template function, instead of macro, for comparison function - Do not sort if the array size is less than or equal to 1 BUG=v8:5953 ========== to ========== [typedarrays] No callbacks for fast sorting of integer typed arrays - No callbacks for std::sort of integer typed arrays when user-defined comparison is not given - Use template function, instead of macro, for comparison function - Do not sort if the array size is less than or equal to 1 BUG=v8:5953 Review-Url: https://codereview.chromium.org/2726153003 Cr-Commit-Position: refs/heads/master@{#43565} Committed: https://chromium.googlesource.com/v8/v8/+/a3709d47e65885ba1dbae086dd8452cbf3c... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/a3709d47e65885ba1dbae086dd8452cbf3c... |
