Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2726133003:
AuthPolicyClient: Remove fallback to string (Closed)
|
Created:
3 years, 9 months ago by Roman Sorokin (ftl) Modified:
3 years, 9 months ago Reviewers:
Thiemo Nagel CC:
chromium-reviews, oshima+watch_chromium.org, hashimoto+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAuthPolicyClient: Remove fallback for D-Bus response.
D-Bus interface response switched from string to protobuf.
We had fallback to string during transition period.
BUG=689000
TEST=manual
Review-Url: https://codereview.chromium.org/2726133003
Cr-Commit-Position: refs/heads/master@{#458408}
Committed: https://chromium.googlesource.com/chromium/src/+/fb3c4f6da7cbc226e293bcc14588ed586126a3fd
Patch Set 1 #
Total comments: 3
Messages
Total messages: 16 (9 generated)
rsorokin@chromium.org changed reviewers: + tnagel@chromium.org
Hey Thiemo, PTAL.
The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/03/02 13:13:46, Roman Sorokin (fast) wrote: > Hey Thiemo, PTAL. Lgtm % nit. Also, "Remove fallback to string" is hard to understand without context, thus maybe you could make it a little clearer?
https://codereview.chromium.org/2726133003/diff/1/chromeos/dbus/auth_policy_c... File chromeos/dbus/auth_policy_client.cc (right): https://codereview.chromium.org/2726133003/diff/1/chromeos/dbus/auth_policy_c... chromeos/dbus/auth_policy_client.cc:135: DLOG(ERROR) << "Failed to parse protobuf."; Nit: Why not use LOG(ERROR)?
Description was changed from ========== AuthPolicyClient: Remove fallback to string Chrome OS changes landed so we don't need the fallback in the D-Bus call anymore BUG=689000 TEST=manual ========== to ========== AuthPolicyClient: Remove fallback for D-Bus response. D-Bus interface response switched from string to protobuf. We had fallback to string during transition period. BUG=689000 TEST=manual ==========
https://codereview.chromium.org/2726133003/diff/1/chromeos/dbus/auth_policy_c... File chromeos/dbus/auth_policy_client.cc (right): https://codereview.chromium.org/2726133003/diff/1/chromeos/dbus/auth_policy_c... chromeos/dbus/auth_policy_client.cc:135: DLOG(ERROR) << "Failed to parse protobuf."; On 2017/03/21 13:30:01, Thiemo Nagel wrote: > Nit: Why not use LOG(ERROR)? Just not to bloat the binary. Should probably delete it cause there is LOG in PopArrayOfBytesAsProto function
https://codereview.chromium.org/2726133003/diff/1/chromeos/dbus/auth_policy_c... File chromeos/dbus/auth_policy_client.cc (right): https://codereview.chromium.org/2726133003/diff/1/chromeos/dbus/auth_policy_c... chromeos/dbus/auth_policy_client.cc:135: DLOG(ERROR) << "Failed to parse protobuf."; > Just not to bloat the binary. Should probably delete it cause there is LOG in > PopArrayOfBytesAsProto function Sounds good.
The CQ bit was checked by rsorokin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490105209663510, "parent_rev":
"a0deb934a1ad2505bf0b9862adc8201cfcda0d68", "commit_rev":
"fb3c4f6da7cbc226e293bcc14588ed586126a3fd"}
Message was sent while issue was closed.
Description was changed from ========== AuthPolicyClient: Remove fallback for D-Bus response. D-Bus interface response switched from string to protobuf. We had fallback to string during transition period. BUG=689000 TEST=manual ========== to ========== AuthPolicyClient: Remove fallback for D-Bus response. D-Bus interface response switched from string to protobuf. We had fallback to string during transition period. BUG=689000 TEST=manual Review-Url: https://codereview.chromium.org/2726133003 Cr-Commit-Position: refs/heads/master@{#458408} Committed: https://chromium.googlesource.com/chromium/src/+/fb3c4f6da7cbc226e293bcc14588... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/fb3c4f6da7cbc226e293bcc14588... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
