[css-grid] Implement transferred size part of Implied Minimum Size

[css-grid] Implement transferred size part of Implied Minimum Size

This part of the spec was not implemented yet
as it was still being discussed in the CSS WG.
The text from the spec [1]:
  "However, if the box has an aspect ratio and no specified size,
   its automatic minimum size is the smaller of its content size
   and its transferred size."

This patch modifies how we compute the automatic minimum size
for replaced elements, in order to use the transferred size
or the content size when required.

BUG=555027
TEST=external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-007.xht
TEST=external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-009.xht

[1] https://drafts.csswg.org/css-flexbox-1/#automatic-minimum-size

Review-Url: https://codereview.chromium.org/2726103003
Cr-Commit-Position: refs/heads/master@{#454248}
Committed: https://chromium.googlesource.com/chromium/src/+/ab779b340b6d4170920e1cf2ce50e67f64d67fac

[Manuel Rego, 2017-03-02 09:12:41]

Description was changed from

==========
[css-grid] Implement transferred size part of Implied Minimum Size

This part of the spec was not implemented yet
as it was still being discussed in the CSS WG.

The text from the spec [1]:
  "However, if the box has an aspect ratio and no specified size,
   its automatic minimum size is the smaller of its content size
   and its transferred size."

The test modifies how we compute the automatic minimum size
for replaced elements, in order to use the transferred size
or the content size when required.

BUG=555027
TEST=external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-007.xht
TEST=external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-009.xht

[1] https://drafts.csswg.org/css-flexbox-1/#automatic-minimum-size
==========

to

==========
[css-grid] Implement transferred size part of Implied Minimum Size

This part of the spec was not implemented yet
as it was still being discussed in the CSS WG.
The text from the spec [1]:
  "However, if the box has an aspect ratio and no specified size,
   its automatic minimum size is the smaller of its content size
   and its transferred size."

This test modifies how we compute the automatic minimum size
for replaced elements, in order to use the transferred size
or the content size when required.

BUG=555027
TEST=external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-007.xht
TEST=external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-009.xht

[1] https://drafts.csswg.org/css-flexbox-1/#automatic-minimum-size
==========

[Manuel Rego, 2017-03-02 09:12:54]

Description was changed from

==========
[css-grid] Implement transferred size part of Implied Minimum Size

This part of the spec was not implemented yet
as it was still being discussed in the CSS WG.
The text from the spec [1]:
  "However, if the box has an aspect ratio and no specified size,
   its automatic minimum size is the smaller of its content size
   and its transferred size."

This test modifies how we compute the automatic minimum size
for replaced elements, in order to use the transferred size
or the content size when required.

BUG=555027
TEST=external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-007.xht
TEST=external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-009.xht

[1] https://drafts.csswg.org/css-flexbox-1/#automatic-minimum-size
==========

to

==========
[css-grid] Implement transferred size part of Implied Minimum Size

This part of the spec was not implemented yet
as it was still being discussed in the CSS WG.
The text from the spec [1]:
  "However, if the box has an aspect ratio and no specified size,
   its automatic minimum size is the smaller of its content size
   and its transferred size."

This patch modifies how we compute the automatic minimum size
for replaced elements, in order to use the transferred size
or the content size when required.

BUG=555027
TEST=external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-007.xht
TEST=external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-009.xht

[1] https://drafts.csswg.org/css-flexbox-1/#automatic-minimum-size
==========

[Manuel Rego, 2017-03-02 09:21:52]

rego@igalia.com changed reviewers:
+ cbiesinger@chromium.org, jfernandez@igalia.com, svillar@igalia.com

[jfernandez, 2017-03-02 11:30:15]

lgtm

[svillar, 2017-03-02 12:00:02]

lgtm too

https://codereview.chromium.org/2726103003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp (right):

https://codereview.chromium.org/2726103003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp:380: if
(childSize.isAuto() && child.isLayoutReplaced()) {
You might want to replace the order of those two checks.

[Manuel Rego, 2017-03-02 12:10:19]

Thanks for the quick reviews!

https://codereview.chromium.org/2726103003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp (right):

https://codereview.chromium.org/2726103003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp:380: if
(childSize.isAuto() && child.isLayoutReplaced()) {
On 2017/03/02 12:00:02, svillar wrote:
> You might want to replace the order of those two checks.

Good point. Done.

[Manuel Rego, 2017-03-02 12:10:23]

The CQ bit was checked by rego@igalia.com

[Manuel Rego, 2017-03-02 12:10:24]

The patchset sent to the CQ was uploaded after l-g-t-m from svillar@igalia.com,
jfernandez@igalia.com
Link to the patchset: https://codereview.chromium.org/2726103003/#ps20001
(title: "Swap order in condition")

[commit-bot: I haz the power, 2017-03-02 12:10:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 13:51:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488456623675180,
"parent_rev": "6a964e37a2eea4ac09dabde38018d675fae85b1b", "commit_rev":
"ab779b340b6d4170920e1cf2ce50e67f64d67fac"}

[commit-bot: I haz the power, 2017-03-02 13:52:22]

Description was changed from

==========
[css-grid] Implement transferred size part of Implied Minimum Size

This part of the spec was not implemented yet
as it was still being discussed in the CSS WG.
The text from the spec [1]:
  "However, if the box has an aspect ratio and no specified size,
   its automatic minimum size is the smaller of its content size
   and its transferred size."

This patch modifies how we compute the automatic minimum size
for replaced elements, in order to use the transferred size
or the content size when required.

BUG=555027
TEST=external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-007.xht
TEST=external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-009.xht

[1] https://drafts.csswg.org/css-flexbox-1/#automatic-minimum-size
==========

to

==========
[css-grid] Implement transferred size part of Implied Minimum Size

This part of the spec was not implemented yet
as it was still being discussed in the CSS WG.
The text from the spec [1]:
  "However, if the box has an aspect ratio and no specified size,
   its automatic minimum size is the smaller of its content size
   and its transferred size."

This patch modifies how we compute the automatic minimum size
for replaced elements, in order to use the transferred size
or the content size when required.

BUG=555027
TEST=external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-007.xht
TEST=external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-009.xht

[1] https://drafts.csswg.org/css-flexbox-1/#automatic-minimum-size

Review-Url: https://codereview.chromium.org/2726103003
Cr-Commit-Position: refs/heads/master@{#454248}
Committed:
https://chromium.googlesource.com/chromium/src/+/ab779b340b6d4170920e1cf2ce50...
==========

[commit-bot: I haz the power, 2017-03-02 13:52:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ab779b340b6d4170920e1cf2ce50...

[cbiesinger, 2017-03-02 19:30:11]

lgtm