Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2726093003: [sensors][android] Add support for AbsoluteOrientation sensor (Closed)

Created:
3 years, 9 months ago by shalamov
Modified:
3 years, 9 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, shalamov, viettrungluu+watch_chromium.org, riju_, agrieve+watch_chromium.org, timvolodine, abarth-chromium, Aaron Boodman, yzshen+watch_chromium.org, wanming.lin, mlamouri+watch-sensors_chromium.org, darin (slow to review), Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sensors][android] Add support for AbsoluteOrientation sensor This CL introduces new sensor type ABSOLUTE_ORIENTATION that is responsible for providing orientation quaternion. Android adaptation for GenericSensor is updated to reflect changes as well as unit tests that verify mapping between mojom and Android sensor type. SensorReading buffer is increased by 8 bytes to accomodate orientation quaternion representation. W3C ED: https://w3c.github.io/orientation-sensor/ BUG=661478 Review-Url: https://codereview.chromium.org/2726093003 Cr-Commit-Position: refs/heads/master@{#458717} Committed: https://chromium.googlesource.com/chromium/src/+/4c6720bb2680945d6fe510f5f4772c62f27b4a9e

Patch Set 1 #

Patch Set 2 : Rebased to master, rename enum #

Messages

Total messages: 20 (14 generated)
shalamov
Tom, could you please take a look at *.mojom modifications. Reilly and Mikhail, ptal at ...
3 years, 9 months ago (2017-03-21 10:28:17 UTC) #12
Mikhail
lgtm
3 years, 9 months ago (2017-03-21 10:46:49 UTC) #13
Reilly Grant (use Gerrit)
lgtm
3 years, 9 months ago (2017-03-21 18:06:30 UTC) #14
Tom Sepez
lgtm
3 years, 9 months ago (2017-03-21 19:14:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726093003/20001
3 years, 9 months ago (2017-03-22 10:34:37 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 11:31:45 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4c6720bb2680945d6fe510f5f477...

Powered by Google App Engine
This is Rietveld 408576698