Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2725973003: Add a use-counter for transforms using the reference box on SVG element (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
Reviewers:
pdr., Ilya Sherman
CC:
fs, blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, krit, fmalita+watch_chromium.org, gyuyoung2, kinuko+watch, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a use-counter for transforms using the reference box on SVG element For gauging the risk of implementing 'transform-box' proper - mostly with an eye towards the initial value. BUG=595829 Review-Url: https://codereview.chromium.org/2725973003 Cr-Commit-Position: refs/heads/master@{#454408} Committed: https://chromium.googlesource.com/chromium/src/+/9c742930a91e7c1affdc9f956ad7b6afd4a0c692

Patch Set 1 #

Patch Set 2 : Rebase; update histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -7 lines) Patch
A third_party/WebKit/LayoutTests/svg/transforms/transform-boxsize-usecounter-1.html View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/transforms/transform-boxsize-usecounter-2.html View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/transforms/transform-boxsize-usecounter-3.html View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/transforms/transform-boxsize-usecounter-4.html View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/transforms/transform-boxsize-usecounter-no-trigger-1.html View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/transforms/transform-boxsize-usecounter-no-trigger-2.html View 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 2 chunks +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/transforms/TranslateTransformOperation.h View 2 chunks +4 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
fs
3 years, 9 months ago (2017-03-02 18:37:05 UTC) #10
pdr.
On 2017/03/02 at 18:37:05, fs wrote: > LGTM
3 years, 9 months ago (2017-03-02 18:39:09 UTC) #11
Ilya Sherman
histograms.xml lgtm
3 years, 9 months ago (2017-03-02 21:18:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725973003/20001
3 years, 9 months ago (2017-03-02 22:26:16 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 22:34:35 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9c742930a91e7c1affdc9f956ad7...

Powered by Google App Engine
This is Rietveld 408576698