Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 2725963002: [Payments] Only show the required rows in the Payment Request dialog (Closed)

Created:
3 years, 9 months ago by Mathieu
Modified:
3 years, 9 months ago
Reviewers:
anthonyvd, head06902
CC:
chromium-reviews, darin-cc_chromium.org, gogerald+paymentswatch_chromium.org, jam, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Only show the required rows in the Payment Request dialog BUG=697595 TEST=PaymentSheet* interactive_ui_tests Review-Url: https://codereview.chromium.org/2725963002 Cr-Commit-Position: refs/heads/master@{#454065} Committed: https://chromium.googlesource.com/chromium/src/+/abf6675b4375b41da3d8fc38014a32c0f7b5e7a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -8 lines) Patch
M chrome/browser/ui/views/payments/payment_sheet_view_controller.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_sheet_view_controller_interactive_uitest.cc View 3 chunks +32 lines, -0 lines 0 comments Download
M components/payments/content/payment_request.h View 1 chunk +5 lines, -0 lines 0 comments Download
M components/payments/content/payment_request.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Mathieu
PTAL!
3 years, 9 months ago (2017-03-01 21:21:19 UTC) #3
anthonyvd
lgtm
3 years, 9 months ago (2017-03-01 21:22:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725963002/1
3 years, 9 months ago (2017-03-01 21:23:14 UTC) #9
head06902
3 years, 9 months ago (2017-03-01 21:23:47 UTC) #11
head06902
lgtm
3 years, 9 months ago (2017-03-01 21:23:48 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 22:17:34 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/abf6675b4375b41da3d8fc38014a...

Powered by Google App Engine
This is Rietveld 408576698