Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2725943003: Respect constrained height on nested multicol containers. (Closed)

Created:
3 years, 9 months ago by mstensho (USE GERRIT)
Modified:
3 years, 9 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Respect constrained height on nested multicol containers. If there's no more space in an inner multicol container (according to e.g. its height or max-height), don't create any additional fragmentainer groups (i.e. column rows). The spec isn't clear here, but this change moves us closer to Edge, and also eliminates cases where we'd previously end up with pathological numbers of fragmentainer groups. Also flipped the logic in hasFragmentainerGroupForColumnAt(), and renamed it to needsNewFragmentainerGroupAt(). BUG=688158 Review-Url: https://codereview.chromium.org/2725943003 Cr-Commit-Position: refs/heads/master@{#454411} Committed: https://chromium.googlesource.com/chromium/src/+/7fa349e632a44c152b05ca6a66ade5f2e5b3f139

Patch Set 1 #

Messages

Total messages: 12 (8 generated)
mstensho (USE GERRIT)
3 years, 9 months ago (2017-03-02 16:47:10 UTC) #6
eae
LGTM
3 years, 9 months ago (2017-03-02 22:26:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725943003/1
3 years, 9 months ago (2017-03-02 22:35:03 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 22:40:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7fa349e632a44c152b05ca6a66ad...

Powered by Google App Engine
This is Rietveld 408576698