[Payments] Add product branding to Payment Request dialog.

[Payments] Add product branding to Payment Request dialog.

Also moved some methods to be protected.

BUG=697567
TEST=manual

Review-Url: https://codereview.chromium.org/2725943002
Cr-Commit-Position: refs/heads/master@{#454639}
Committed: https://chromium.googlesource.com/chromium/src/+/a9c98fe41922e15781579818eff47ff6e1ef645e

[Mathieu, 2017-03-01 19:51:54]

Description was changed from

==========
[Payments] Add product branding to Payment Request dialog.

BUG=697567
TEST=manual
==========

to

==========
[Payments] Add product branding to Payment Request dialog.

Also moved some methods to be protected.

BUG=697567
TEST=manual
==========

[Mathieu, 2017-03-01 19:51:54]

mathp@chromium.org changed reviewers:
+ anthonyvd@chromium.org

[Mathieu, 2017-03-01 19:53:40]

mathp@chromium.org changed reviewers:
+ grt@chromium.org

[Mathieu, 2017-03-01 19:53:40]

grt@chromium.org: Please review changes in theme_resources.grd

Anthony, please review the whole change?

[Mathieu, 2017-03-01 19:53:50]

Patchset #1 (id:1) has been deleted

[anthonyvd, 2017-03-01 19:58:21]

lgtm

https://codereview.chromium.org/2725943002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/payment_sheet_view_controller.cc (right):

https://codereview.chromium.org/2725943002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_sheet_view_controller.cc:222: // Adds
the Chrome logo to the footer.
nit: Since this isn't always Chrome, can you make comments and variable names
refer to "product" instead?

[Mathieu, 2017-03-01 20:13:04]

Thanks

https://codereview.chromium.org/2725943002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/payment_sheet_view_controller.cc (right):

https://codereview.chromium.org/2725943002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_sheet_view_controller.cc:222: // Adds
the Chrome logo to the footer.
On 2017/03/01 19:58:21, anthonyvd wrote:
> nit: Since this isn't always Chrome, can you make comments and variable names
> refer to "product" instead?

well we are in chrome/browser/ui/... Do you mean the Chromium/Chrome
distinction?

I've added Chromium in the comment, but for ASCII art I prefer only having
"chrome".

[Mathieu, 2017-03-02 14:40:47]

On 2017/03/01 20:13:04, Mathieu Perreault wrote:
> Thanks
> 
>
https://codereview.chromium.org/2725943002/diff/20001/chrome/browser/ui/views...
> File chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
(right):
> 
>
https://codereview.chromium.org/2725943002/diff/20001/chrome/browser/ui/views...
> chrome/browser/ui/views/payments/payment_sheet_view_controller.cc:222: // Adds
> the Chrome logo to the footer.
> On 2017/03/01 19:58:21, anthonyvd wrote:
> > nit: Since this isn't always Chrome, can you make comments and variable
names
> > refer to "product" instead?
> 
> well we are in chrome/browser/ui/... Do you mean the Chromium/Chrome
> distinction?
> 
> I've added Chromium in the comment, but for ASCII art I prefer only having
> "chrome".

I'll wait for resolution on https://codereview.chromium.org/2726793004/ to move
the Chrome logo resource around. Also this is not time critical so will land
after branch. Can hold off the review!

[Mathieu, 2017-03-02 15:56:06]

https://codereview.chromium.org/2725943002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/payment_sheet_view_controller.cc (right):

https://codereview.chromium.org/2725943002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_sheet_view_controller.cc:222: // Adds
the Chrome logo to the footer.
On 2017/03/01 20:13:04, Mathieu Perreault wrote:
> On 2017/03/01 19:58:21, anthonyvd wrote:
> > nit: Since this isn't always Chrome, can you make comments and variable
names
> > refer to "product" instead?
> 
> well we are in chrome/browser/ui/... Do you mean the Chromium/Chrome
> distinction?
> 
> I've added Chromium in the comment, but for ASCII art I prefer only having
> "chrome".

Reworded even more!

[grt (UTC plus 2), 2017-03-03 10:07:26]

chrome/app rubberstamp lgtm. in the future, you may TBR .grd changes provided
that you have UX approval for the change.

[Mathieu, 2017-03-03 18:07:22]

Patchset #4 (id:80001) has been deleted

[Mathieu, 2017-03-03 18:07:56]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-03-03 18:07:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
anthonyvd@chromium.org, grt@chromium.org
Link to the patchset: https://codereview.chromium.org/2725943002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-03 18:08:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 19:09:40]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1488564476113120,
"parent_rev": "3f4bae9092c2ac1443f2c26867b7fad7f10df1ca", "commit_rev":
"a9c98fe41922e15781579818eff47ff6e1ef645e"}

[commit-bot: I haz the power, 2017-03-03 19:10:18]

Description was changed from

==========
[Payments] Add product branding to Payment Request dialog.

Also moved some methods to be protected.

BUG=697567
TEST=manual
==========

to

==========
[Payments] Add product branding to Payment Request dialog.

Also moved some methods to be protected.

BUG=697567
TEST=manual

Review-Url: https://codereview.chromium.org/2725943002
Cr-Commit-Position: refs/heads/master@{#454639}
Committed:
https://chromium.googlesource.com/chromium/src/+/a9c98fe41922e15781579818eff4...
==========

[commit-bot: I haz the power, 2017-03-03 19:10:19]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/a9c98fe41922e15781579818eff4...