tests/compiler/dart2js/analyze_unused_dart2js_test.dart - Issue 2725933006: Reduce use of elements/resolution_types in enqueuer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/analyze_unused_dart2js_test.dart

Issue 2725933006: Reduce use of elements/resolution_types in enqueuer. (Closed)

Patch Set: Updated cf. comment. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/compiler/dart2js/analyze_unused_dart2js_test.dart

diff --git a/tests/compiler/dart2js/analyze_unused_dart2js_test.dart b/tests/compiler/dart2js/analyze_unused_dart2js_test.dart

index ae753a2191b076fd8da85bd269bb0fcd02b0f9db..c73aee5dbe7e833f345179491ce97502efb2604d 100644

--- a/tests/compiler/dart2js/analyze_unused_dart2js_test.dart

+++ b/tests/compiler/dart2js/analyze_unused_dart2js_test.dart

@@ -61,7 +61,7 @@ bool checkResults(Compiler compiler, CollectingDiagnosticHandler handler) {

currentDirectory.resolve('pkg/compiler/lib/src/helpers/helpers.dart');

void checkLive(member) {

if (member.isFunction) {

- if (compiler.enqueuer.resolution.hasBeenProcessed(member)) {

+ if (compiler.resolutionWorldBuilder.isMemberUsed(member)) {

compiler.reporter.reportHintMessage(member, MessageKind.GENERIC,

{'text': "Helper function in production code '$member'."});

}