Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2725883003: Merged: Don't use DCHECK in v8-util.h. (Closed)

Created:
3 years, 9 months ago by Michael Hablich
Modified:
3 years, 9 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, Paweł Hajdan Jr., ulan
Target Ref:
refs/pending/branch-heads/5.8
Project:
v8
Visibility:
Public.

Description

Merged: Don't use DCHECK in v8-util.h. Revision: 60991f990b2ec0efe57668c499091695ac416f39 BUG=chromium:688155 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2725883003 . Cr-Commit-Position: refs/branch-heads/5.8@{#4} Cr-Branched-From: eda659cc5e307f20ac1ad542ba12ab32eaf4c7ef-refs/heads/5.8.283@{#1} Cr-Branched-From: 4310cd02d2160b1457baed81a2f40063eb264a21-refs/heads/master@{#43429} Committed: https://chromium.googlesource.com/v8/v8/+/40008aa5dfaea16a4c0086733e5dab9a1312f98f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M include/v8-util.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Hablich
3 years, 9 months ago (2017-03-02 11:54:43 UTC) #1
Michael Hablich
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 9 months ago (2017-03-02 11:54:45 UTC) #2
Michael Hablich
Committed patchset #1 (id:1) manually as 40008aa5dfaea16a4c0086733e5dab9a1312f98f.
3 years, 9 months ago (2017-03-02 11:54:59 UTC) #4
Michael Achenbach
3 years, 9 months ago (2017-03-02 12:36:03 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698