Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2725883002: bindings: Add ToV8() overload for HeapVector<std::pair<String, T>>. (Closed)

Created:
3 years, 9 months ago by Raphael Kubo da Costa (rakuco)
Modified:
3 years, 9 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Add ToV8() overload for HeapVector<std::pair<String, T>>. record<K,V> WebIDL support part 3. The upcoming record<K,V> WebIDL type will be represented by a HeapVector<std::pair<String, T>> when T is either a Member<U>. Add a ToV8() overload that is identical to the existing one for Vector<std::pair<String, T>> so all kinds of records can be serialized back to V8. BUG=685754 R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org Review-Url: https://codereview.chromium.org/2725883002 Cr-Commit-Position: refs/heads/master@{#454226} Committed: https://chromium.googlesource.com/chromium/src/+/c463181850479e23e89ebd766fbe1fa2990d9d51

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -6 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ToV8.h View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp View 2 chunks +30 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Raphael Kubo da Costa (rakuco)
PTAL. I think this bit from https://codereview.chromium.org/2709983004/ is also fairly uncontroversial, so I'd rather land ...
3 years, 9 months ago (2017-03-01 15:42:14 UTC) #1
bashi
lgtm
3 years, 9 months ago (2017-03-01 23:19:17 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-03-01 23:40:53 UTC) #4
Yuki
LGTM.
3 years, 9 months ago (2017-03-02 05:52:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725883002/1
3 years, 9 months ago (2017-03-02 08:10:49 UTC) #7
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 9 months ago (2017-03-02 10:06:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725883002/1
3 years, 9 months ago (2017-03-02 10:19:38 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 10:24:08 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c463181850479e23e89ebd766fbe...

Powered by Google App Engine
This is Rietveld 408576698