gpu/config: Use angle::GetSystemInfo on Linux

gpu/config: Use angle::GetSystemInfo on Linux

BUG=angleproject:1874
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2725873007
Cr-Commit-Position: refs/heads/master@{#457433}
Committed: https://chromium.googlesource.com/chromium/src/+/873b27d518038be94df98d1128a2e8047e0ef942

[Corentin Wallez, 2017-03-03 20:34:58]

Description was changed from

==========
gpu/config: Use angle::GetSystemInfo on Linux

BUG=angleproject:1874
==========

to

==========
gpu/config: Use angle::GetSystemInfo on Linux

BUG=angleproject:1874
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2017-03-03 20:38:18]

cwallez@chromium.org changed reviewers:
+ zmo@chromium.org

[Corentin Wallez, 2017-03-03 20:38:19]

PTAL, I will land this once https://chromium-review.googlesource.com/c/450037/
is landed and rolled.

Also the removal of libXNVCtrl from Chrome will be done in a follow-up CL.

[Zhenyao Mo, 2017-03-04 00:37:38]

On 2017/03/03 20:38:19, Corentin Wallez wrote:
> PTAL, I will land this once https://chromium-review.googlesource.com/c/450037/
> is landed and rolled.
> 
> Also the removal of libXNVCtrl from Chrome will be done in a follow-up CL.

This is really nice.  One suggestion for you to consider: is it better we just
incorporate angle::SysInfo as part of GPUInfo?

If you want to land as is, that's OK too. LGTM

[Corentin Wallez, 2017-03-07 00:30:04]

On 2017/03/04 at 00:37:38, zmo wrote:
> On 2017/03/03 20:38:19, Corentin Wallez wrote:
> > PTAL, I will land this once
https://chromium-review.googlesource.com/c/450037/
> > is landed and rolled.
> > 
> > Also the removal of libXNVCtrl from Chrome will be done in a follow-up CL.
> 
> This is really nice.  One suggestion for you to consider: is it better we just
incorporate angle::SysInfo as part of GPUInfo?
> 
> If you want to land as is, that's OK too. LGTM

Thanks, making gpu/config use angle::SystemInfo directly could be done as a
follow-up. It would be too much work to do it right now, especially since it has
a slightly different structure than GPUInfo.

[Corentin Wallez, 2017-03-07 23:14:55]

The CQ bit was checked by cwallez@chromium.org

[Corentin Wallez, 2017-03-07 23:14:56]

The ANGLE change has been rolled, CQing this.

[commit-bot: I haz the power, 2017-03-07 23:15:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 23:21:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 23:21:36]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Corentin Wallez, 2017-03-08 00:01:34]

Description was changed from

==========
gpu/config: Use angle::GetSystemInfo on Linux

BUG=angleproject:1874
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu/config: Use angle::GetSystemInfo on Linux

BUG=angleproject:1874
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2017-03-08 00:01:50]

The CQ bit was checked by cwallez@chromium.org

[Corentin Wallez, 2017-03-08 00:01:50]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2725873007/#ps100001
(title: "Add ANGLE to the DEPS")

[commit-bot: I haz the power, 2017-03-08 00:03:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 00:08:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 00:08:38]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Zhenyao Mo, 2017-03-08 01:04:59]

On 2017/03/08 00:08:38, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
>   mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
>   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
>   mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

You are breaking an include rule and need to update it.

[Corentin Wallez, 2017-03-08 02:00:50]

On 2017/03/08 at 01:04:59, zmo wrote:
> On 2017/03/08 00:08:38, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
> >
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> >   mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
> >
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
> >   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
> >
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
> >   mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
> >
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
> 
> You are breaking an include rule and need to update it.

I did modify gpu/config/DEPS though, is something else needed?

[Zhenyao Mo, 2017-03-08 17:26:14]

On 2017/03/08 02:00:50, Corentin Wallez wrote:
> On 2017/03/08 at 01:04:59, zmo wrote:
> > On 2017/03/08 00:08:38, commit-bot: I haz the power wrote:
> > > Try jobs failed on following builders:
> > >   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
> > >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> > >   mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac
(JOB_FAILED,
> > >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
> > >   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
> > >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
> > >   mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
> > >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
> > 
> > You are breaking an include rule and need to update it.
> 
> I did modify gpu/config/DEPS though, is something else needed?

I don't know gn well, but it seems that you need to modify BUILD.gn's
"config_source"

[Zhenyao Mo, 2017-03-08 17:27:59]

On 2017/03/08 17:26:14, Zhenyao Mo wrote:
> On 2017/03/08 02:00:50, Corentin Wallez wrote:
> > On 2017/03/08 at 01:04:59, zmo wrote:
> > > On 2017/03/08 00:08:38, commit-bot: I haz the power wrote:
> > > > Try jobs failed on following builders:
> > > >   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
> > > >
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> > > >   mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac
> (JOB_FAILED,
> > > >
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
> > > >   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
> > > >
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
> > > >   mac_optional_gpu_tests_rel on master.tryserver.chromium.mac
(JOB_FAILED,
> > > >
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
> > > 
> > > You are breaking an include rule and need to update it.
> > 
> > I did modify gpu/config/DEPS though, is something else needed?
> 
> I don't know gn well, but it seems that you need to modify BUILD.gn's
> "config_source"

The conditional deps needs to be for all platforms (this does seem like a bug in
analyze though, could you file a bug for it?)

[Corentin Wallez, 2017-03-09 16:18:51]

On 2017/03/08 at 17:27:59, zmo wrote:
> On 2017/03/08 17:26:14, Zhenyao Mo wrote:
> > On 2017/03/08 02:00:50, Corentin Wallez wrote:
> > > On 2017/03/08 at 01:04:59, zmo wrote:
> > > > On 2017/03/08 00:08:38, commit-bot: I haz the power wrote:
> > > > > Try jobs failed on following builders:
> > > > >   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
> > > > >
> > >
> >
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> > > > >   mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac
> > (JOB_FAILED,
> > > > >
> > >
> >
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
> > > > >   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
> > > > >
> > >
> >
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
> > > > >   mac_optional_gpu_tests_rel on master.tryserver.chromium.mac
(JOB_FAILED,
> > > > >
> > >
> >
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
> > > > 
> > > > You are breaking an include rule and need to update it.
> > > 
> > > I did modify gpu/config/DEPS though, is something else needed?
> > 
> > I don't know gn well, but it seems that you need to modify BUILD.gn's
> > "config_source"
> 
> The conditional deps needs to be for all platforms (this does seem like a bug
in analyze though, could you file a bug for it?)

I'm able to reproduce locally, so it should be easy to fix the error, or
diagnose the bug.

I'm postponing the landing of this CL until a test checking GetSystemInfo works
is added.

[Corentin Wallez, 2017-03-15 23:00:31]

On 2017/03/09 at 16:18:51, Corentin Wallez wrote:
> On 2017/03/08 at 17:27:59, zmo wrote:
> > On 2017/03/08 17:26:14, Zhenyao Mo wrote:
> > > On 2017/03/08 02:00:50, Corentin Wallez wrote:
> > > > On 2017/03/08 at 01:04:59, zmo wrote:
> > > > > On 2017/03/08 00:08:38, commit-bot: I haz the power wrote:
> > > > > > Try jobs failed on following builders:
> > > > > >   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
> > > > > >
> > > >
> > >
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> > > > > >   mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac
> > > (JOB_FAILED,
> > > > > >
> > > >
> > >
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
> > > > > >   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
> > > > > >
> > > >
> > >
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
> > > > > >   mac_optional_gpu_tests_rel on master.tryserver.chromium.mac
(JOB_FAILED,
> > > > > >
> > > >
> > >
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
> > > > > 
> > > > > You are breaking an include rule and need to update it.
> > > > 
> > > > I did modify gpu/config/DEPS though, is something else needed?
> > > 
> > > I don't know gn well, but it seems that you need to modify BUILD.gn's
> > > "config_source"
> > 
> > The conditional deps needs to be for all platforms (this does seem like a
bug in analyze though, could you file a bug for it?)
> 
> I'm able to reproduce locally, so it should be easy to fix the error, or
diagnose the bug.
> 
> I'm postponing the landing of this CL until a test checking GetSystemInfo
works is added.

The test has landed, and the addition of //nogncheck fixed the gn check locally.

[Corentin Wallez, 2017-03-15 23:00:35]

The CQ bit was checked by cwallez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 23:01:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2017-03-15 23:07:45]

lgtm

[commit-bot: I haz the power, 2017-03-16 01:39:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 01:39:34]

Dry run: This issue passed the CQ dry run.

[Corentin Wallez, 2017-03-16 14:50:36]

The CQ bit was checked by cwallez@chromium.org

[Corentin Wallez, 2017-03-16 14:50:37]

Thanks for the re-review, the test seems to have stuck except on Mac Asan, I'
looking at the failure now.

[commit-bot: I haz the power, 2017-03-16 14:50:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 14:55:19]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1489675836872040,
"parent_rev": "4d954851ba9c129b4529302f77862f6b812165d8", "commit_rev":
"873b27d518038be94df98d1128a2e8047e0ef942"}

[commit-bot: I haz the power, 2017-03-16 14:56:01]

Description was changed from

==========
gpu/config: Use angle::GetSystemInfo on Linux

BUG=angleproject:1874
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu/config: Use angle::GetSystemInfo on Linux

BUG=angleproject:1874
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2725873007
Cr-Commit-Position: refs/heads/master@{#457433}
Committed:
https://chromium.googlesource.com/chromium/src/+/873b27d518038be94df98d1128a2...
==========

[commit-bot: I haz the power, 2017-03-16 14:56:02]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/873b27d518038be94df98d1128a2...