Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 2725873006: [merge m57] Prefer returning a SingleThreadTaskRunner in SequencedTaskRunnerHandle::Get(). (Closed)

Created:
3 years, 9 months ago by fdoray
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[merge m57] Prefer returning a SingleThreadTaskRunner in SequencedTaskRunnerHandle::Get(). Currently: - When a thread has a SingleThreadTaskRunner but not SequencedTaskRunner, SequencedTaskRunnerHandle::Get() and ThreadTaskRunnerHandle::Get() are equivalent. - ThreadTaskRunnerHandle::Get() can only be called from a thread that has a SingleThreadTaskRunner. - Having both a SequencedTaskRunner and a SingleThreadTaskRunner on the same thread is prevented by a DCHECK. That means that replacing ThreadTaskRunnerHandle::Get() with SequencedTaskRunnerHandle::Get() shouldn't change anything. Unfortunately, RLZ sets a SingleThreadTaskRunner on a thread that already has a SequencedTaskRunner. To make the replacement of ThreadTaskRunnerHandle::Get() with SequencedTaskRunnerHandle::Get() a true no-op under the assumption that a SingleThreadTaskRunner can be registered on a thread that already has a SequencedTaskRunner, this CL gives priority to the SingleThreadTaskRunner in SequencedTaskRunnerHandle::Get(). This change will be reverted once RLZ stops setting a SingleThreadTaskRunner on a thread that already has a SequencedTaskRunner. BUG=693711, 618530 Review-Url: https://codereview.chromium.org/2714813005 Cr-Commit-Position: refs/heads/master@{#452980} (cherry picked from commit 533c31e78be276dcaa843dc66efd4fee697d9573) Review-Url: https://codereview.chromium.org/2725873006 . Cr-Commit-Position: refs/branch-heads/2987@{#748} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/06bad34f6516d13a5b39beea0e575431f0a803a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M base/threading/sequenced_task_runner_handle.cc View 1 chunk +27 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fdoray
3 years, 9 months ago (2017-03-03 03:57:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
06bad34f6516d13a5b39beea0e575431f0a803a2.

Powered by Google App Engine
This is Rietveld 408576698