Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2725873003: 📰 Initialise suggestion cards favicon space (Closed)

Created:
3 years, 9 months ago by dgn
Modified:
3 years, 9 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Client] Initialise suggestion cards favicon space This reserves the space to be occupied by the favicon once it the callback getting it from the local storage returns. This avoid the text from being visibly pushed out while on screen. BUG=697458 Review-Url: https://codereview.chromium.org/2725873003 Cr-Commit-Position: refs/heads/master@{#453990} Committed: https://chromium.googlesource.com/chromium/src/+/ff1402f96bc21441eb7a8950d44adac9e67622ee

Patch Set 1 #

Patch Set 2 : always set the default favicon #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java View 1 3 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
dgn
PTAL
3 years, 9 months ago (2017-03-01 18:31:52 UTC) #2
Bernhard Bauer
LGTM!
3 years, 9 months ago (2017-03-01 18:39:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725873003/20001
3 years, 9 months ago (2017-03-01 18:54:14 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 19:12:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ff1402f96bc21441eb7a8950d44a...

Powered by Google App Engine
This is Rietveld 408576698