Bug Fix: List Too Small When Sharing Tab Only

chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc

Index: chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
diff --git a/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc b/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
index 5ed6dc073d13a4eb9bec24af688c11a634c5529b..3e19d797192b3f0878f8a030e888fcb09511e2a1 100644
--- a/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
+++ b/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
@@ -169,8 +169,8 @@ DesktopMediaPickerDialogView::DesktopMediaPickerDialogView(
         this, std::move(tab_list), kTabStyle, kTabStyle, tab_title_text));
 
     tab_scroll_view->SetContents(list_views_.back());
-    tab_scroll_view->ClipHeightTo(kTabStyle.item_size.height(),
-                                  kTabStyle.item_size.height() * 2);
+    tab_scroll_view->ClipHeightTo(kTabStyle.item_size.height() * 7,

[msw, 2017/03/01 19:00:03]

Can you post some screenshots of before and after? What happens when the
dialog's minimum height (now 7 times the old minimum height) exceeds the
available height of the browser window? Should the minimum be left alone, but
the maximum increased?

[qiangchen, 2017/03/01 20:59:42]

Reduce it to 5. As 5 * tab height is almost 1 * window height.

Attached screenshot on crbug

[msw, 2017/03/01 23:26:48]

nit: I still think it might be better to use just one tab height for the
minimum. That way the dialog will still shrink the tab selection area to show
the Cancel/Share buttons, even when the parent chrome window is *super* short.
Otherwise, what's the point of showing 5 tabs if you can't click Share? (please
test out super short chrome windows and lmk what you think).

[qiangchen, 2017/03/03 16:39:32]

Done.

+                                  kTabStyle.item_size.height() * 10);
     tab_scroll_view->set_hide_horizontal_scrollbar(true);
     tab_scroll_view->set_background(
         views::Background::CreateSolidBackground(bg_color));